feat: upgraded gridstack to v12#151
Merged
kevinhinterlong merged 1 commit intoJun 2, 2025
Merged
Conversation
FilipKujavec
commented
May 22, 2025
| this.items.forEach(({ id, options }) => { | ||
| assert.dom(`[data-id="${id}"]`).hasAttribute('gs-x', `${options.x}`, 'Initial grid-stack-item layout is correct'); | ||
| assert.dom(`[data-id="${id}"]`).hasAttribute('gs-y', `${options.y}`, 'Initial grid-stack-item layout is correct'); | ||
| if (options.x === 0) { |
Contributor
Author
There was a problem hiding this comment.
gs-* attributes now get removed if their value is the default/min size
| .doesNotHaveAttribute('gs-y', 'Updating a grid-stack-item leaves unaffected items the same'); | ||
|
|
||
| assert.dom(`[data-id="1"]`).hasAttribute('gs-x', '2', 'Updating a grid-stack-item updates moves the item'); | ||
| assert.dom(`[data-id="1"]`).doesNotHaveAttribute('gs-x', 'Updating a grid-stack-item updates moves the item'); |
Contributor
Author
There was a problem hiding this comment.
gridstack's update() function now calls nodeBoundFix() which leads to the item being moved before being resized like before
Contributor
Author
|
@kevinhinterlong could you take a look at this PR? |
kevinhinterlong
approved these changes
Jun 2, 2025
Member
kevinhinterlong
left a comment
kevinhinterlong
left a comment
There was a problem hiding this comment.
Looks good, thank you @FilipKujavec!
Collaborator
|
🎉 This PR is included in version 5.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.