Switch blktap licensing to GPLv2#442
Open
AnthoineB wants to merge 6 commits into
Open
Conversation
atomicio() is still available in VHD. Signed-off-by: Emmanuel Varagnat <emmanuel.varagnat@vates.tech>
The journal used atomicio() from atomicio.c/.h, which carry a separate OpenBSD license. Replace it with vhd_atomic_io() / vhd_atomic_pio() in the new io-util.c, under the same license as the rest of the tree. vhd_atomic_pio() is the positioned helper moved out of libvhd.c; vhd_atomic_io() is the sequential read/write variant. Signed-off-by: Emmanuel Varagnat <emmanuel.varagnat@vates.tech>
Signed-off-by: Anthoine Bourgeois <anthoine.bourgeois@vates.tech>
Signed-off-by: Anthoine Bourgeois <anthoine.bourgeois@vates.tech>
Signed-off-by: Anthoine Bourgeois <anthoine.bourgeois@vates.tech>
All files in this package are now licensed under a GPLv2 license. Please see the LICENSE file for details. Signed-off-by: Anthoine Bourgeois <anthoine.bourgeois@vates.tech>
Contributor
|
I approve. |
|
Could we use SPDX license identifiers instead (https://spdx.dev/learn/handling-license-info/) ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Vates storage team would like to add support of VDI above 2TB.
To allow this we'd like to support Qcow2 format in the blktap component.
To help the development of this feature, we would like to import Qcow2 code from the Qemu implementation.
Since Qemu's code is licensed under GPLv2, we would like to also switch the global blktap license to GPLv2 to avoid license incompatibility.
Therefore, I am contacting all external contributors to get their approval on their commits to make this switch.
We will wait at least 2 weeks to get their feedback by email before considering merging this PR.
In the meantime, this PR is open to review.
There are 2 parts in the PR:
atomicio.c,list.h,aio_genevents.c,autogen.sh)