-
Notifications
You must be signed in to change notification settings - Fork 36
feat: introduce pnpm -r flag with build command #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: sunrabbit123 <[email protected]>
| ], | ||
| "scripts": { | ||
| "build": "node deploy/build", | ||
| "build": "pnpm -r build", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but failed with packages/compiler-browser-test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and it's code ignore private field
The existing code worked correctly by excluding packages marked as private.
But idk why ignore private package in script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you think? @Reviewer
|
I don't think we can simply use
The second one will be problematic. Do you have any idea to keep the build order safe? |
But we can't solve the number 1 |
|
Um, than why don't you remove "problematic" packages from the workspace and try again? I think the "private" ones (including But you might want to make some packages "public" again ( |
|
The functionality itself can be made to work one way or another. The purpose of the private field is to prevent publishing. Therefore, since a package with a private field that is set contrary to the package manager's intended use cannot be ignored at the pnpm level, we must instead modify the build process to include all packages. This raises the question of whether such a change would go against the original intent of the person who designed the package structure. This is not about an error or malfunction—I'm simply asking for an opinion. If the current private setting is intentional, then the PR loses its value, and there’s no reason to proceed with it. thank you for reading |
This pull request simplifies the build process by removing a custom build script and replacing it with a more efficient workspace-based build command using
pnpm.Build process simplification:
deploy/build.jsscript, which handled package builds manually by iterating through packages and running build commands.buildscript inpackage.jsonto usepnpm -r build, leveragingpnpm's recursive workspace feature for building all packages.