Skip to content

Use pointer cursor for icon buttons #5002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 26, 2025
Merged

Use pointer cursor for icon buttons #5002

merged 4 commits into from
Mar 26, 2025

Conversation

anbraten
Copy link
Member

similar to #4982
@anbraten anbraten added bug Something isn't working ui frontend related labels Mar 24, 2025
@anbraten anbraten changed the title fix: use pointer cursor for icon buttons Use pointer cursor for icon buttons Mar 24, 2025
@anbraten anbraten requested a review from a team March 24, 2025 13:52
@xoxys
Copy link
Member

xoxys commented Mar 24, 2025 •
edited
Loading

Why the change to the icon buttons? Those are native a elements and have a pointer anyway.

Edit: Nevermind was looking at the wrong button.
@xoxys
Copy link
Member

xoxys commented Mar 24, 2025

Switching in some places to const btnClass approach looks inconsistent to me. If we dont want to use the inline style apply approach anymore fine but I would prefer to apply it everywhere then. The new approach makes it impossible to find out whats defined in the class by hovering over it:

image
@xoxys xoxys force-pushed the fix-icon-btn-cursor branch from 49af009 to 8f240ea Compare March 25, 2025 19:59
@xoxys
Copy link
Member

xoxys commented Mar 25, 2025

I reverted the change to use btnClass for the given reason. This can be done for and discussed in a separate PR, hope you are ok with that.
@xoxys xoxys requested a review from a team March 25, 2025 20:01
@xoxys xoxys merged commit 2aecfdc into main Mar 26, 2025
7 checks passed
@xoxys xoxys deleted the fix-icon-btn-cursor branch March 26, 2025 12:51
@woodpecker-bot woodpecker-bot mentioned this pull request Mar 26, 2025
Merged
1 task
@woodpecker-bot woodpecker-bot mentioned this pull request Apr 2, 2025
Closed
1 task
@BrewTestBot BrewTestBot mentioned this pull request Apr 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ui frontend related
3 participants
@anbraten @xoxys @qwerty287