Skip to content

fix: Remove unused v dependency#517

Merged
alexander-akait merged 1 commit into
webpack:masterfrom
askoufis:remove-v-dep
May 31, 2023
Merged

fix: Remove unused v dependency#517
alexander-akait merged 1 commit into
webpack:masterfrom
askoufis:remove-v-dep

Conversation

@askoufis

@askoufis askoufis commented May 31, 2023

Copy link
Copy Markdown
Contributor

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Seems like a dependency on the v package was added during this chore PR. This seems like an accident to me as the v package doesn't seem related at all to less-loader.

@ctjhoa

ctjhoa commented May 31, 2023

Copy link
Copy Markdown

I came to the same conclusion and I agree,
In addition, this dependency is annoying because it brings deasync which relies on
node-gyp internally (notorious for being clunky).

@codecov

codecov Bot commented May 31, 2023

Copy link
Copy Markdown

Codecov Report

Patch and project coverage have no change.

Comparison is base (8b9c873) 93.37% compared to head (710ac31) 93.37%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #517   +/-   ##
=======================================
  Coverage   93.37%   93.37%           
=======================================
  Files           3        3           
  Lines         151      151           
  Branches       33       33           
=======================================
  Hits          141      141           
  Misses         10       10           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants