layout: Make the implementation of used TransformStyle more complete - #60593
Merged
servo-wpt-sync merged 1 commit intoJun 16, 2026
Merged
Conversation
wpt-pr-bot
approved these changes
Jun 12, 2026
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Servo project.
servo-wpt-sync
force-pushed
the
servo_export_45629
branch
from
June 13, 2026 06:18
97b6109 to
4e88c94
Compare
servo-wpt-sync
changed the title
get_used_transform_styleTransformStyle more complete
servo-wpt-sync
force-pushed
the
servo_export_45629
branch
4 times, most recently
from
June 16, 2026 13:23
d0598d3 to
addde8f
Compare
Stylo was using a very incomplete method for calculating the used `TransformStyle` for boxes, which didn't incorporate all of the grouping properties from the specification. This change moves the functionality into Servo (as cannot properly compute this value without `FragmentFlags`) and makes it more complete. We still do not process the value of `contain`, `mask-iamge`, and `mask-boarder-source` as we do not support those values yet. Incidentally, this also fixes a panic that we were causing in WebRender, probably by going down a path that Gecko does not exercise. Stylo PR: servo/stylo#388 Signed-off-by: Martin Robinson <martin@abandonedwig.info>
servo-wpt-sync
force-pushed
the
servo_export_45629
branch
from
June 16, 2026 13:55
addde8f to
60dfbd4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stylo was using a very incomplete method for calculating the used
TransformStylefor boxes, which didn't incorporate all of the groupingproperties from the specification. This change moves the functionality
into Servo (as cannot properly compute this value without
FragmentFlags) and makes it more complete. We still do not process thevalue of
contain,mask-image, andmask-border-sourceas we do notsupport those values yet.
Incidentally, this also fixes a panic that we were causing in WebRender,
probably by going down a path that Gecko does not exercise.
Stylo PR: servo/stylo#388
Testing: This adds a new crashtest. Three other WPT tests start to pass.
Fixes: #42476.
Reviewed in servo/servo#45629