[Gecko Bug 1920115] Allow selecting tasks from all existing web schedulers for main thread#50908
Merged
Conversation
wpt-pr-bot
approved these changes
Feb 24, 2025
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Firefox project.
moz-wptsync-bot
force-pushed
the
gecko/1920115
branch
from
b9926cb to
d40201c
Compare
This is a missing step in the current implementation. When we about to select a task, it should pick one from all scheduled tasks, including the ones scheduled by different schedulers. Differential Revision: https://phabricator.services.mozilla.com/D236948 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1920115 gecko-commit: 41d90165c19adfa61486484b7ffb5ccab599461c gecko-reviewers: jjaschke, smaug
Instead of passing a single `AbortSignal` argument to `CreateTask`, we now separate it into a `AbortSignal` and a `TaskSignal`. They could be the same when `TaskController` is used, and if its `AbortController`, only `AbortSignal` is non-null. Differential Revision: https://phabricator.services.mozilla.com/D239178 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1920115 gecko-commit: 00dc9f4af854b9ad0096aabf57e8a9cb19fda858 gecko-reviewers: smaug
moz-wptsync-bot
force-pushed
the
gecko/1920115
branch
from
d40201c to
ca62f27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a missing step in the current implementation. When we about
to select a task, it should pick one from all scheduled tasks, including
the ones scheduled by different schedulers.
Differential Revision: https://phabricator.services.mozilla.com/D236948
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1920115
gecko-commit: 7522970c5a1d2f0cb2dad9cd4249ae5d0e222c14
gecko-reviewers: jjaschke, smaug