Skip to content

Add support for cancel backups#1264

Merged
dirkkul merged 10 commits into
mainfrom
list_backups
Oct 8, 2024
Merged

Add support for cancel backups#1264
dirkkul merged 10 commits into
mainfrom
list_backups

Conversation

@dirkkul

@dirkkul dirkkul commented Aug 28, 2024

Copy link
Copy Markdown
Collaborator

List backups has been moved back, but I'll leave the code that has already been written in there

@dirkkul dirkkul requested a review from a team as a code owner August 28, 2024 11:51
@dirkkul dirkkul marked this pull request as draft August 28, 2024 11:51
@dirkkul dirkkul changed the title Add support for list backups Add support for list and cancel backups Aug 29, 2024
Comment thread weaviate/backup/backup.py Outdated
@dirkkul dirkkul changed the base branch from dev/1.27 to main October 8, 2024 09:11
@dirkkul dirkkul changed the title Add support for list and cancel backups Add support for cancel backups Oct 8, 2024
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 44.18605% with 24 lines in your changes missing coverage. Please review.

Project coverage is 94.27%. Comparing base (624e2e2) to head (26da9be).
Report is 66 commits behind head on main.

Files with missing lines Patch % Lines
weaviate/backup/backup.py 37.03% 17 Missing ⚠️
integration_v3/test_backup_v4.py 41.66% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1264      +/-   ##
==========================================
- Coverage   94.38%   94.27%   -0.11%     
==========================================
  Files         220      220              
  Lines       20953    20993      +40     
==========================================
+ Hits        19776    19792      +16     
- Misses       1177     1201      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dirkkul dirkkul marked this pull request as ready for review October 8, 2024 10:54
Comment thread integration_v3/test_backup_v4.py
Comment thread integration_v3/test_backup_v4.py Outdated
Comment thread weaviate/backup/backup.py Outdated
Comment thread weaviate/backup/backup.py Outdated
Comment thread weaviate/backup/backup.py Outdated
Comment thread weaviate/backup/backup.py
@dirkkul dirkkul merged commit 51614e5 into main Oct 8, 2024
@dirkkul dirkkul deleted the list_backups branch October 8, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants