Fix browsing context checks for Switch To Parent Frame when already the top-level browsing context#1556
Merged
Merged
Conversation
…he top-level browsing context.
whimboo
requested review from
AutomatedTester,
andreastt,
jgraham and
shs96c
as code owners
Contributor
|
Are there tests for this? |
1 similar comment
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
If those changes make sense I will immediately file a bug, and add new tests, or update existing ones. |
Contributor
|
Makes sense to me |
Contributor
Author
|
There is https://bugzilla.mozilla.org/show_bug.cgi?id=1671622 now. |
Contributor
Author
|
Patch for the updated tests has been uploaded and is under review now. |
AutomatedTester
approved these changes
Oct 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #1544.
@jgraham or someone else, can you please review? Thanks
Preview | Diff