Skip to content

Serialization description for position property #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jm318 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Serialization description for position property #463

jm318 wants to merge 3 commits into from

Conversation

@jm318
Copy link
Contributor

@jm318 jm318 commented Aug 22, 2017

@shans PTAL, thanks!
tabatkins
tabatkins reviewed Aug 22, 2017
View reviewed changes
css-typed-om/Overview.bs Outdated

: 'position'
::
1. Return value of 'position'.
Copy link
Member

@tabatkins tabatkins Aug 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "value of 'position'" is a browser-internal abstract CSS value, which can't be returned directly to JS. It needs to be serialized as a keyword, like in the other examples.
Copy link
Contributor Author

@jm318 jm318 Aug 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks!
@jm318
Copy link
Contributor Author

jm318 commented Aug 23, 2017

@tabatkins, thanks for the review! PTAL.
Base automatically changed from master to main February 2, 2021 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@jm318 @tabatkins