Skip to content

Editorial: Update computation step "comp_embedded_control" (formerly step 2c) text for clarity#2299

Open
MelSumner wants to merge 3 commits into
mainfrom
melsumner/accname-244
Open

Editorial: Update computation step "comp_embedded_control" (formerly step 2c) text for clarity#2299
MelSumner wants to merge 3 commits into
mainfrom
melsumner/accname-244

Conversation

@MelSumner
Copy link
Copy Markdown
Contributor

@MelSumner MelSumner commented Jul 31, 2024

Closes accname issue 244

If merged, this PR updates step "comp_embedded_control" (formerly step 2c) to be the agreed upon text per this issue: w3c/accname#244

If merged, this PR updates step 2C to be the agreed upon text per this issue: w3c/accname#244
@netlify
Copy link
Copy Markdown

netlify Bot commented Jul 31, 2024

Deploy Preview for wai-aria ready!

Name Link
🔨 Latest commit 9c24b90
🔍 Latest deploy log https://app.netlify.com/projects/wai-aria/deploys/682f6349f5a1f700072b3420
😎 Deploy Preview https://deploy-preview-2299--wai-aria.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@MelSumner MelSumner requested review from accdc and aleventhal July 31, 2024 20:39
@MelSumner MelSumner added editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo spec:accname labels Jul 31, 2024
@MelSumner MelSumner changed the title Update index.html Update computation step 2c text for clarity Jul 31, 2024
@jnurthen jnurthen requested a review from cookiecrook August 1, 2024 17:10
@MelSumner MelSumner changed the title Update computation step 2c text for clarity [accname] Update computation step 2c text for clarity Aug 8, 2024
Comment thread accname/index.html Outdated
Comment thread accname/index.html
@accdc
Copy link
Copy Markdown
Contributor

accdc commented Aug 8, 2024

Simply referring to control sounds good to me if it's clear to everyone else.

@scottaohara
Copy link
Copy Markdown
Member

the argument about just saying "control" is that a display none control's value should not participate. and i'd also argue that one should not anticipate a input type=checkbox value=nope would have its value participate either.

a non-hidden control with a user-perceivable value (e.g., text input value or chosen option from a select, but not checkbox or radio button value) seems more like what we would actually want covered here.

@cookiecrook
Copy link
Copy Markdown
Contributor

a non-hidden control with a user-perceivable value (e.g., text input value or chosen option from a select, but not checkbox or radio button value) seems more like what we would actually want covered here.

"user-perceivable value" for a checkbox (true or false, checked or unchecked) would also be perceivable. If that's the case, the value for each control type would need to be specified. Yuck.

Should it be limited this to "user-perceivable control with a string value"?

@scottaohara
Copy link
Copy Markdown
Member

when i was referring to value i meant the string value. e.g., input type=checkbox value=foo the state (checked or not) shouldn't be considered as part of the calculation. agreed that'd be yucky.

@spectranaut spectranaut changed the title [accname] Update computation step 2c text for clarity Update computation step 2c text for clarity Aug 19, 2024
@spectranaut spectranaut changed the title Update computation step 2c text for clarity Editorial: Update computation step 2c text for clarity Aug 19, 2024
@cookiecrook cookiecrook changed the title Editorial: Update computation step 2c text for clarity Editorial: Update computation step "comp_embedded_control" (formerly step 2c) text for clarity Nov 15, 2024
Co-authored-by: James Craig <cookiecrook@users.noreply.github.com>
@MelSumner MelSumner self-assigned this May 22, 2025
@MelSumner
Copy link
Copy Markdown
Contributor Author

@MelSumner note for myself to rebase and also address comments that don't have suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo spec:accname

7 participants