Add UnionScalar#8739
Open
connortsui20 wants to merge 2 commits into
Open
Conversation
Signed-off-by: "Connor Tsui" <connor.tsui20@gmail.com>
Merging this PR will not alter performance
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing 
Footnotes
|
12 tasks
connortsui20
force-pushed
the
ct/union-scalar
branch
4 times, most recently
from
7e619d3 to
243969b
Compare
connortsui20
commented
Jul 13, 2026
Comment on lines
+27
to
+35
| // Union nullability is part of its variant dtypes, so the generic nullability-only cast | ||
| // below is not valid for unions. Keep all non-identity union casts unsupported until their | ||
| // semantics are defined. | ||
| if matches!(self.dtype(), DType::Union(_)) || matches!(target_dtype, DType::Union(_)) { | ||
| vortex_bail!( | ||
| "non-identity union scalar cast from {} to {target_dtype} is not supported", | ||
| self.dtype() | ||
| ); | ||
| } |
Member
Author
There was a problem hiding this comment.
Interested in what people think about how we should deal with this
connortsui20
force-pushed
the
ct/union-scalar
branch
3 times, most recently
from
8bb8db6 to
7925944
Compare
connortsui20
commented
Jul 13, 2026
| /// We implement `Hash` manually so top-level dtype nullability does not affect the hash. | ||
| impl Hash for Scalar { | ||
| fn hash<H: Hasher>(&self, state: &mut H) { | ||
| // TODO(connor): Recursively ignore dtype nullability to match Scalar equality (#8744). |
connortsui20
force-pushed
the
ct/union-scalar
branch
3 times, most recently
from
43d2fc9 to
9de7663
Compare
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
connortsui20
force-pushed
the
ct/union-scalar
branch
from
9de7663 to
4893177
Compare
Comment on lines
+63
to
+67
| dtype: &'a DType, | ||
| /// The variants of the union. | ||
| /// | ||
| /// We store this here as a convenience so that we do not need to unwrap the dtype every time. | ||
| variants: &'a UnionVariants, |
Contributor
There was a problem hiding this comment.
Should we just store the nullability here so we don't need the DType at all?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Tracking Issue: #7882
UnionScalaris the row representation needed for scalar access and constant arrays before the canonicalUnionArray. Non-null values store the selected type ID and childScalarValue; null remains on the outerScalar, avoiding a second null layer.What changes are included in this PR?
UnionValue,UnionScalar, construction, downcasts, validation, display, equality, hashing, defaults, and sizingConstantArrayscalar access coverageTested with
cargo nextest run -p vortex-arrayandcargo clippy --all-targets --all-features.What APIs are changed? Are there any user-facing changes?
Adds
ScalarValue::Union,UnionValue,UnionScalar,Scalar::union, and the Union scalar downcasts.