Lint em-dash chars - #7899
Conversation
…e replaces with simpler text
github-project-automation
Bot
moved this to Top priorities
in HLS.js Release Planning and Backlog
github-project-automation
Bot
moved this from Top priorities
to Done
in HLS.js Release Planning and Backlog
| { | ||
| selector: | ||
| 'Literal[value=/\u2014/], TemplateElement[value.cooked=/\u2014/] ', | ||
| message: 'Em-dash (—) is not allowed. Use a hyphen (-) instead.', |
There was a problem hiding this comment.
why not just disable all non-ASCII (> U+007F) chars? any non-ASCII will cause v8 to store entire bundle as two-byte (UTF-16) string instead of one-byte (Latin1) doubling its heap footprint per worker
There was a problem hiding this comment.
any non-ASCII will cause v8 to store entire bundle as two-byte (UTF-16) string
I'm not so sure about that. The babel-rollup build is not doubled in size, and I'd expect v8 to operate on a string by string basis. You're welcome to submit a change, to help identify other chars.
There was a problem hiding this comment.
The babel-rollup build is not doubled in size
I meant v8 will store worker string in UTF-16 instead of Latine1.
Or what did you mean by saying babel-rollup build is not doubled in size
2 participants
This PR will...
Lint characters that require UTF encoding in the source.
Why is this Pull Request needed?
So that can be replaces with simpler text.