Skip to content

Remove Hive legacy security#21013

Merged
electrum merged 4 commits into
trinodb:masterfrom
electrum:hive-legacy-security
Mar 12, 2024
Merged

Remove Hive legacy security#21013
electrum merged 4 commits into
trinodb:masterfrom
electrum:hive-legacy-security

Conversation

@electrum
Copy link
Copy Markdown
Member

@electrum electrum commented Mar 11, 2024 •
edited
Loading

Description

Remove Hive legacy security. The new default is allow-all.

Release notes

(x) Release notes are required, with the following suggested text:

# Hive connector
* The `legacy` mode for `hive.security` has been removed, and the default is now `allow-all`.
  Use `read-only` if you want to prevent write operations, or use `file` for fine-grained control.
  The legacy properties `hive.allow-drop-table`, `hive.allow-rename-table`,
    `hive.allow-add-column`, `hive.allow-drop-column`
    `hive.allow-rename-column`, `hive.allow-comment-table`,
  and `hive.allow-comment-column` must be removed. ({issue}`21013`)
@electrum electrum requested review from dain and mosabua March 11, 2024 20:12
@cla-bot cla-bot Bot added the cla-signed label Mar 11, 2024
@github-actions github-actions Bot added docs tests:hive iceberg Iceberg connector delta-lake Delta Lake connector hive Hive connector labels Mar 11, 2024
@electrum electrum force-pushed the hive-legacy-security branch from 408603b to 0fb5e40 Compare March 11, 2024 20:16
@mosabua mosabua mentioned this pull request Mar 11, 2024
Merged
@electrum electrum force-pushed the hive-legacy-security branch 2 times, most recently from 35e893f to 0fc477e Compare March 11, 2024 21:27
@mosabua
Copy link
Copy Markdown
Member

mosabua commented Mar 11, 2024

Docs change is fine .. just really depends now what you want to merge first .. this PR or #21015

I am fine either way
@electrum electrum force-pushed the hive-legacy-security branch from 0fc477e to 4909d31 Compare March 11, 2024 21:32
@electrum electrum force-pushed the hive-legacy-security branch from 4909d31 to 58e2f39 Compare March 11, 2024 21:32
mosabua
mosabua approved these changes Mar 11, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs are good and I slightly updated the release notes suggestion
@mosabua
Copy link
Copy Markdown
Member

mosabua commented Mar 11, 2024

Also note @colebow the release notes entry needs the {{breaking}}
@mosabua
Copy link
Copy Markdown
Member

mosabua commented Mar 11, 2024

Can you clarify in which connector doc sections in the release notes this needs to be added @electrum .. I think Hive, Iceberg, and Delta Lake .. but not Hudi .. but I might be wrong
@electrum
Copy link
Copy Markdown
Member Author

electrum commented Mar 12, 2024

This only affects Hive. The other connector changes are just cleanups, so that the code is similar in all connectors.
@electrum electrum merged commit d158382 into trinodb:master Mar 12, 2024
@electrum electrum deleted the hive-legacy-security branch March 12, 2024 21:03
@github-actions github-actions Bot added this to the 441 milestone Mar 12, 2024
@mosabua
Copy link
Copy Markdown
Member

mosabua commented Mar 13, 2024

💥
@colebow colebow mentioned this pull request Mar 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed delta-lake Delta Lake connector docs hive Hive connector iceberg Iceberg connector

3 participants

@electrum @mosabua @dain