Use DefaultAzureCredential by default for Azure file system#20996
Merged
Conversation
findinpath
reviewed
Mar 8, 2024
| public class AzureAuthDefault | ||
| implements AzureAuth | ||
| { | ||
| private final TokenCredential credential = new DefaultAzureCredentialBuilder().build(); |
Contributor
There was a problem hiding this comment.
How can this auth be tested in the integration tests?
Or is it more a convenience method for local testing while doing az login ?
Member
Author
There was a problem hiding this comment.
This is for parity with S3 DefaultCredentialsProvider, so that Azure can be enabled by default. I don't think we need to test, since that would be testing the Azure SDK rather than our code.
dain
approved these changes
Mar 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.