Rewrite statistics during OPTIMIZE in Iceberg#20885
Merged
Merged
Conversation
pajaks
changed the title
pajaks
changed the title
pajaks
commented
Mar 1, 2024
|
|
||
| // For optimize we need to set task_min_writer_count to 1, otherwise it will create more than one file. | ||
| computeActual(withSingleWriterPerTask(getSession()), "ALTER TABLE " + tableName + " EXECUTE OPTIMIZE WHERE regionkey = 4"); | ||
| computeActual(withSingleWriterPerTask(getSession()), "ALTER TABLE " + tableName + " EXECUTE OPTIMIZE WHERE regionkey = 3"); |
Member
Author
There was a problem hiding this comment.
Row deleted has regionkey = 3
alexjo2144
reviewed
Mar 5, 2024
alexjo2144
reviewed
Mar 5, 2024
findinpath
reviewed
Mar 5, 2024
Contributor
There was a problem hiding this comment.
Can this happen in case of a rollback_to_snapshot ?
Member
Author
There was a problem hiding this comment.
I think rollback_to_snapshot can cause that is some special case and race condition. I followed what is done for finishInsert where we also write statistics file.
trino/plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java
Lines 1132 to 1134 in 23569fc
pajaks
force-pushed
the
pajaks/rewrite_stats_optimize
branch
from
eddabb0 to
d2338f4
Compare
pajaks
force-pushed
the
pajaks/rewrite_stats_optimize
branch
from
d2338f4 to
7345d65
Compare
findinpath
approved these changes
Mar 8, 2024
alexjo2144
approved these changes
Mar 9, 2024
homar
approved these changes
Mar 9, 2024
ebyhr
approved these changes
Mar 11, 2024
pajaks
force-pushed
the
pajaks/rewrite_stats_optimize
branch
from
53eccd9 to
e424326
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #19992
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: