Skip to content

Add deprecation and future disabling of playstore builds warning to banner#7493

Merged
agnostic-apollo merged 2 commits into
termux:masterfrom
agnostic-apollo:change-banner-for-playstore-builds
Sep 10, 2021
Merged

Add deprecation and future disabling of playstore builds warning to banner#7493
agnostic-apollo merged 2 commits into
termux:masterfrom
agnostic-apollo:change-banner-for-playstore-builds

Conversation

@agnostic-apollo

@agnostic-apollo agnostic-apollo commented Sep 8, 2021

Copy link
Copy Markdown
Member

Sorry for the duplicate. I forgot to re-commit before force pushing after undoing the single commit.

@Grimler91 and @buttaface thanks for the suggestions. I have tried to incorporate them from both of you. Its slightly shorter and will show even if banner is disabled.

I can't really say "The termux apps will be removed from Play store", since that requires involvement from @fornwall, who hasn't been responding on emails/sms.

I have updated https://github.com/termux/termux-app#installation as well and added deprecation details.

Let me know of any further changes.

playstore-banner

@Grimler91

Copy link
Copy Markdown
Member

Looks good!

This:

.. so that new users
cannot install them and to **disable** them for
existing users with updates so that they do not
continue using outdated versions.

could be modified to make it clear who "they" are in the second part of the sentence. Perhaps:

.. so that new users
cannot install them and to **disable** them for
existing users with app updates to prevent the use 
of outdated app versions.
@agnostic-apollo
agnostic-apollo force-pushed the change-banner-for-playstore-builds branch from d800a48 to d1a911b Compare September 8, 2021 23:26
@agnostic-apollo

Copy link
Copy Markdown
Member Author

@Grimler91 Done!

If someone else doesn't suggest changes in next few hours, I'll bump termux-tools version.

@RalfWerner

Copy link
Copy Markdown

Do it, even if I do not mean playstore users have an advantage of it.

nikooseyfi07

This comment was marked as spam.

Bryant-Coulson93

This comment was marked as spam.

Bryant-Coulson93

This comment was marked as spam.

ImL1s pushed a commit to ImL1s/termux-packages that referenced this pull request May 1, 2026
…-playstore-builds

Bump termux-tools to 0.135
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants