-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
chore: use closures for state proxies #12912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks impressive. Here's the benchmark I was using. Toggle create 10k rows and clear. |
How does that compare to |
(also, what of the memory impact — manageable?) |
Since the performance characteristics look okay, I've expanded on this in #12916 |
alternative to #12868. This doesn't yet change any behaviour (apart from the one slightly odd test that has been updated), this is just to get a sense of the performance implications
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint