feat: support polling straight from auth login#78
Open
kreese-stripe wants to merge 2 commits into
Open
Conversation
danhill-stripe
requested changes
May 6, 2026
|
|
||
| ```bash | ||
| link-cli auth login --client-name "<your-agent-name>" | ||
| link-cli auth login --client-name "<your-agent-name>" --interval 5 --timeout 300 |
Contributor
There was a problem hiding this comment.
I don't think we should make this the default behavior. Agents seem good with the _next output?
| const deadline = Date.now() + c.options.timeout * 1000; | ||
| let attempts = 0; | ||
|
|
||
| while (true) { |
Contributor
There was a problem hiding this comment.
is this code repeated in the other auth polling command?
|
|
||
| // Inline polling: emit code to stderr (visible immediately even while | ||
| // stdout is buffered), then yield it as structured output for MCP streaming. | ||
| process.stderr.write( |
Contributor
There was a problem hiding this comment.
should be json output/respect the output format
kreese-stripe
force-pushed
the
kreese/auth-polling
branch
from
dfcbadf to
734e30c
Compare
Comment on lines
+79
to
+86
| if (c.format === 'json') { | ||
| process.stderr.write( | ||
| `${JSON.stringify({ verification_url: authRequest.verification_url_complete, phrase: authRequest.user_code })}\n`, | ||
| ); | ||
| } else { | ||
| process.stderr.write( | ||
| `\nVerification URL: ${authRequest.verification_url_complete}\nPhrase: ${authRequest.user_code}\n\nOpen the URL, log in to Link, and enter the phrase to approve.\nPolling for approval...\n\n`, | ||
| ); |
Contributor
There was a problem hiding this comment.
I don't think you need this? incur should handle the output format for you, you just need to return the object
Contributor
There was a problem hiding this comment.
or yield the object
Contributor
danhill-stripe
left a comment
danhill-stripe
left a comment
There was a problem hiding this comment.
I also think we need the sanitizeDeep on the output too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We received feedback (from an agent using
link-cli!) that theauth status --interval N --max-attempts Mis a long-running blocking command that blocked the agent's I/O, and so they weren't able to relay the code to the human until they stopped polling.To fix this, we instead allow starting the polling straight from the
auth logincommandTest Plan:
Old behavior - no changes
Old behavior - no format -> interactive mode
New Behavior - outputs as JSON when formatted
