Fix RelationKey unquoted issue. Fixes #137 #228
Conversation
Brooke-white
force-pushed
the
sacko87-unquoted
branch
from
33a6f70 to
8f3f8e4
Compare
There was a problem hiding this comment.
Integration tests are passing, so the logic and tests here look good.
I left one style suggestion, but I'm open to pushback on that.
I don't think any documentation change is needed for this, but we do need to update CHANGES.rst. Can you go ahead and add a change entry under "0.8.5 (unreleased)" that links to this PR?
sqlalchemy_redshift/dialect.py
Outdated
| def unquote(part): | ||
| if ( | ||
| part is not None and part.startswith('"') and | ||
| part.endswith('"') | ||
| ): | ||
| return part[1:-1] | ||
| return part |
There was a problem hiding this comment.
This would feel more pythonic to me if we moved this to be a class method _unquote rather than defining this function nested inside the unquoted method. I'm not used to seeing nested functions.
|
thanks for the review! I've pushed changes addressing your feedback. |
There was a problem hiding this comment.
Looks ready to go. I'm going to commit the staticmethod change and rerun integration tests, then I'll go ahead and merge once it's green.
Thanks for this first contribution, @Brooke-white!
|
Integration tests weren't able to complete due to credit balance with Travis-ci.com; I'm contacting their support, but in the meanwhile, going ahead and merging this change. |
#184 reopened
Addresses PR feedback from @novotl regarding
RelationKey.unquoted()return type & test modificationsAddresses PR feedback from @graingert regarding use of
pytest.mark.parameterize.MIT compatible
Tests
Documentation
Updated CHANGES.rst
toxhas been run, no test failures seen.