Skip to content

pin to requests 2.31 to resolve docker library error#150

Merged
patel-bhavin merged 2 commits into
mainfrom
fix_requests_bug
May 22, 2024
Merged

pin to requests 2.31 to resolve docker library error#150
patel-bhavin merged 2 commits into
mainfrom
fix_requests_bug

Conversation

@pyth0n1c

@pyth0n1c pyth0n1c commented May 20, 2024

Copy link
Copy Markdown
Contributor

This morning, python requests library 2.32 was pushed.
However, this breaks docker-py: docker/docker-py#3256

Since docker-py is a dependency, we must pin to request ~2.31 for now

We also have added setuptools, which is not installed by default in Python 3.12: Link to Python 3.12 release notes
To pyproject.toml since it is used in pycvesearch: https://github.com/cve-search/PyCVESearch/blob/6a492a72f95ea96f1ef56109d138dfa344d7e9ec/pycvesearch/core.py#L4

pyth0n1c and others added 2 commits May 20, 2024 13:42
docker library error
… longer installed by default in python 3.12 environments. However, pycvesearch uses/requires it, so we install it.
@ljstella

Copy link
Copy Markdown
Contributor

requests 2.32.0 and 2.32.1 were both yanked with 2.32.2 being the new release. However, I believe we actually need docker-py's next release which includes a more stable fix. That release appears to be in-progress (docker/docker-py#3262) but is not yet available.

@patel-bhavin

Copy link
Copy Markdown
Contributor

Merging this query and then will create another PR when a more stable fix is out!

@patel-bhavin patel-bhavin merged commit 42953e3 into main May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants