Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: socketio/socket.io-redis-adapter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 623593d
Choose a base ref
...
head repository: socketio/socket.io-redis-adapter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5e82a3b
Choose a head ref
  • 12 commits
  • 13 files changed
  • 5 contributors

Commits on May 24, 2023

  1. chore: bump socket.io-parser from 4.2.2 to 4.2.3 (#503)

    Bumps [socket.io-parser](https://github.com/socketio/socket.io-parser) from 4.2.2 to 4.2.3.
    - [Release notes](https://github.com/socketio/socket.io-parser/releases)
    - [Changelog](https://github.com/socketio/socket.io-parser/blob/main/CHANGELOG.md)
    - [Commits](socketio/socket.io-parser@4.2.2...4.2.3)
    
    ---
    updated-dependencies:
    - dependency-name: socket.io-parser
      dependency-type: indirect
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored May 24, 2023
    Configuration menu
    Copy the full SHA
    ef5f0da View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2024

  1. fix(sharded): fix count in fetchSockets() method (#523)

    If `fetchSockets()` is called shortly after the adapter was
    initialized, the server count may still return 0, causing this to fail
    with "timeout reached: only 0 responses received out of -1".
    MartinKolarik authored Feb 19, 2024
    Configuration menu
    Copy the full SHA
    bd32763 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. fix(sharded): fix SSUBSCRIBE memory leak with ioredis (#529)

    This pull request introduces a change to the sharded adapter's `SSUBSCRIBE` logic: Previously, for each dynamic channel/room, a unique listener was added to the client's `smessageBuffer`. This approach led to a large number of listeners (resulting in `MaxListenersExceededWarning`), especially in scenarios with many dynamic channels. Further, listeners were not being removed when unsubscribing, leading to a memory leak.
    
    The new implementation replaces the multiple listeners with a single `smessageBuffer` listener. This listener is registered once and handles all dynamic channels by maintaining specific channel handlers in a `Map`. Listeners are added to this `Map` in `SSUBSCRIBE` and removed from the `Map` in `SUNSUBSCRIBE`.
    
    Related: #528
    RoccoC authored Mar 13, 2024
    Configuration menu
    Copy the full SHA
    2113e8d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cca38dc View commit details
    Browse the repository at this point in the history
  3. docs: update compatibility table (#530)

    Related: #424
    SubJunk authored Mar 13, 2024
    Configuration menu
    Copy the full SHA
    740e6eb View commit details
    Browse the repository at this point in the history
  4. refactor: use the ClusterAdapter class from socket.io-adapter package

    The ClusterAdapter class has been moved to [1], so that this adapter
    only needs to implement to pub/sub mechanism.
    
    Also, [2] should reduce the number of "timeout reached: only x
    responses received out of y" errors, since the fetchSockets() requests
    will now succeed even if a server leaves the cluster.
    
    [1]: https://github.com/socketio/socket.io-adapter
    [2]: socketio/socket.io-adapter@0e23ff0
    
    See also: socketio/socket.io-adapter@2.5.2...2.5.4
    darrachequesne committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    7fb6b90 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    372f7e9 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a69d825 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    dc1407f View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    50220f4 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    f95176d View commit details
    Browse the repository at this point in the history
  10. chore(release): 8.3.0

    darrachequesne committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    5e82a3b View commit details
    Browse the repository at this point in the history
Loading