-
Notifications
You must be signed in to change notification settings - Fork 486
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: socketio/socket.io-redis-adapter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 623593d
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: socketio/socket.io-redis-adapter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5e82a3b
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 12 commits
- 13 files changed
- 5 contributors
Commits on May 24, 2023
-
chore: bump socket.io-parser from 4.2.2 to 4.2.3 (#503)
Bumps [socket.io-parser](https://github.com/socketio/socket.io-parser) from 4.2.2 to 4.2.3. - [Release notes](https://github.com/socketio/socket.io-parser/releases) - [Changelog](https://github.com/socketio/socket.io-parser/blob/main/CHANGELOG.md) - [Commits](socketio/socket.io-parser@4.2.2...4.2.3) --- updated-dependencies: - dependency-name: socket.io-parser dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for ef5f0da - Browse repository at this point
Copy the full SHA ef5f0daView commit details
Commits on Feb 19, 2024
-
fix(sharded): fix count in fetchSockets() method (#523)
If `fetchSockets()` is called shortly after the adapter was initialized, the server count may still return 0, causing this to fail with "timeout reached: only 0 responses received out of -1".
Configuration menu - View commit details
-
Copy full SHA for bd32763 - Browse repository at this point
Copy the full SHA bd32763View commit details
Commits on Mar 13, 2024
-
fix(sharded): fix SSUBSCRIBE memory leak with ioredis (#529)
This pull request introduces a change to the sharded adapter's `SSUBSCRIBE` logic: Previously, for each dynamic channel/room, a unique listener was added to the client's `smessageBuffer`. This approach led to a large number of listeners (resulting in `MaxListenersExceededWarning`), especially in scenarios with many dynamic channels. Further, listeners were not being removed when unsubscribing, leading to a memory leak. The new implementation replaces the multiple listeners with a single `smessageBuffer` listener. This listener is registered once and handles all dynamic channels by maintaining specific channel handlers in a `Map`. Listeners are added to this `Map` in `SSUBSCRIBE` and removed from the `Map` in `SUNSUBSCRIBE`. Related: #528
Configuration menu - View commit details
-
Copy full SHA for 2113e8d - Browse repository at this point
Copy the full SHA 2113e8dView commit details -
Configuration menu - View commit details
-
Copy full SHA for cca38dc - Browse repository at this point
Copy the full SHA cca38dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 740e6eb - Browse repository at this point
Copy the full SHA 740e6ebView commit details -
refactor: use the ClusterAdapter class from socket.io-adapter package
The ClusterAdapter class has been moved to [1], so that this adapter only needs to implement to pub/sub mechanism. Also, [2] should reduce the number of "timeout reached: only x responses received out of y" errors, since the fetchSockets() requests will now succeed even if a server leaves the cluster. [1]: https://github.com/socketio/socket.io-adapter [2]: socketio/socket.io-adapter@0e23ff0 See also: socketio/socket.io-adapter@2.5.2...2.5.4
Configuration menu - View commit details
-
Copy full SHA for 7fb6b90 - Browse repository at this point
Copy the full SHA 7fb6b90View commit details -
Configuration menu - View commit details
-
Copy full SHA for 372f7e9 - Browse repository at this point
Copy the full SHA 372f7e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for a69d825 - Browse repository at this point
Copy the full SHA a69d825View commit details -
Configuration menu - View commit details
-
Copy full SHA for dc1407f - Browse repository at this point
Copy the full SHA dc1407fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 50220f4 - Browse repository at this point
Copy the full SHA 50220f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for f95176d - Browse repository at this point
Copy the full SHA f95176dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e82a3b - Browse repository at this point
Copy the full SHA 5e82a3bView commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 623593d...5e82a3b