Address support on OIDC provisioners#156
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #156 +/- ##
==========================================
+ Coverage 68.32% 68.33% +<.01%
==========================================
Files 61 61
Lines 8351 8353 +2
==========================================
+ Hits 5706 5708 +2
Misses 2276 2276
Partials 369 369
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for a listenAddress property in the OIDC provisioners that allows defining a fixed port for those OIDC providers that don't support a random port, like Okta or Auth0.
If the OIDC provisioner defines a listen address the oauth command will be executed with the flag
--listen <listenAddress>.Fixes #150
Requires smallstep/certificates#105