Skip to content

Add subject to the list of SANs in cloud providers#118

Merged
maraino merged 2 commits into
masterfrom
iid-common-names
Jul 20, 2019
Merged

Add subject to the list of SANs in cloud providers#118
maraino merged 2 commits into
masterfrom
iid-common-names

Conversation

@maraino
Copy link
Copy Markdown
Collaborator

@maraino maraino commented Jul 19, 2019

Description

Add subject to the list of SANs in cloud providers if disableCustomSANs is set to false.

This PR also includes a fix in zcrypto to support new provisioners smallstep/zcrypto@0eaa490

@maraino maraino requested a review from dopey July 19, 2019 23:48
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 19, 2019

Codecov Report

Merging #118 into master will decrease coverage by 0.2%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #118      +/-   ##
==========================================
- Coverage   69.28%   69.07%   -0.21%     
==========================================
  Files          61       61              
  Lines        8224     8249      +25     
==========================================
  Hits         5698     5698              
- Misses       2158     2183      +25     
  Partials      368      368
Impacted Files Coverage Δ
jose/types.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e723c6...1cb595b. Read the comment docs.

Copy link
Copy Markdown
Contributor

@dopey dopey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@maraino maraino merged commit 94ae060 into master Jul 20, 2019
@maraino maraino deleted the iid-common-names branch July 20, 2019 00:11
mcarbonneaux pushed a commit to mcarbonneaux/smallstep-cli that referenced this pull request Nov 25, 2025
…/golang.org/x/net-0.36.0

Bump golang.org/x/net from 0.34.0 to 0.36.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants