feat(components): changed sonner defaults to use lucide icons #7620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@jguddas is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
shadcn
requested changes
Jun 18, 2025
Collaborator
shadcn
left a comment
shadcn
left a comment
There was a problem hiding this comment.
I like this. Can we make the change to apps/v4/registry/new-york-v4/ui/sonner.tsx instead?
(I want to make all updates to the new components and then potentially backport to the v3 versions.)
shadcn
added
area: roadmap
# Conflicts: # apps/v4/public/r/styles/new-york-v4/registry.json # apps/v4/public/r/styles/new-york-v4/sonner.json # apps/v4/registry.json # apps/v4/registry/__index__.tsx # apps/v4/registry/registry-examples.ts # apps/www/public/r/styles/new-york-v4/registry.json # apps/www/public/r/styles/new-york-v4/sonner.json
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
2qp
pushed a commit
to 2qp/shadcn-ui
that referenced
this pull request
Oct 14, 2025
…-ui#7620) * feat(components): changed sonner defaults to use lucide icons * Update new-york-v4 sonner.tsx * fix: icons and docs * fix * fix --------- Co-authored-by: shadcn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid mixing icon sets, we can provide lucide icons to sonner as nice cohesive defaults.
Before:
After:
