-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
fix: 🐛 title color for code block in light mode #3552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@flixlix is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
|
@flixlix can you also add some images after resolving this issue soo we can see essely what's changes you make |
|
|
||
| [data-rehype-pretty-code-title] { | ||
| @apply mt-2 pt-6 px-4 text-sm font-medium; | ||
| @apply mt-2 pt-6 px-4 text-sm font-medium text-foreground; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change looks better than #3519
|
@shadcn can you please review this one when you have a sec? This should be a quick for a pretty important UI / a11y issue in the docs: |
|
This PR has been automatically marked as stale due to one year of inactivity. It will be closed in 7 days unless there’s further input. If you believe this PR is still relevant, please leave a comment or provide updated details. Thank you. (This is an automated message) |
|
This PR has been automatically closed due to one year of inactivity. Thank you for your understanding! (This is an automated message) |



Dark mode
in dark mode the title above the code block worked fine.
Light mode
In light mode, the title wouldn't appear, because the background was also white.
Selected Text
Here you can see that the text is still rendered in light mode.