Skip to content

Conversation

@flixlix
Copy link
Contributor

@flixlix flixlix commented Apr 20, 2024

Dark mode

in dark mode the title above the code block worked fine.

image

Light mode

In light mode, the title wouldn't appear, because the background was also white.

image

Selected Text

Here you can see that the text is still rendered in light mode.

image
@vercel
Copy link
Contributor

vercel bot commented Apr 20, 2024

@flixlix is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

@ruru-m07
Copy link

@flixlix can you also add some images after resolving this issue soo we can see essely what's changes you make


[data-rehype-pretty-code-title] {
@apply mt-2 pt-6 px-4 text-sm font-medium;
@apply mt-2 pt-6 px-4 text-sm font-medium text-foreground;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change looks better than #3519

@flixlix
Copy link
Contributor Author

flixlix commented Apr 22, 2024

@flixlix can you also add some images after resolving this issue soo we can see essely what's changes you make

@ruru-m07 here you go:

image
@kachkaev
Copy link
Contributor

@shadcn can you please review this one when you have a sec? This should be a quick for a pretty important UI / a11y issue in the docs:

https://ui.shadcn.com/docs/theming#list-of-variables

Screenshot 2024-06-19 at 13 35 21
Screenshot 2024-06-19 at 13 35 28

@shadcn
Copy link
Collaborator

shadcn commented Jun 19, 2025

This PR has been automatically marked as stale due to one year of inactivity. It will be closed in 7 days unless there’s further input. If you believe this PR is still relevant, please leave a comment or provide updated details. Thank you. (This is an automated message)

@shadcn shadcn added the stale? Is this issue stale? label Jun 19, 2025
@shadcn
Copy link
Collaborator

shadcn commented Jun 27, 2025

This PR has been automatically closed due to one year of inactivity. Thank you for your understanding! (This is an automated message)

@shadcn shadcn closed this Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale? Is this issue stale?

4 participants