Support color-scheme in Servo - #438
Conversation
|
Is there a corresponding Servo PR for this change? Typically for Stylo PRs they should have a link to a Servo PR unless it is guaranteed to not change test results / affect the build. |
|
It's still a draft as I ran out of time to create the Servo PR. Once I have that finished, I will mark this PR as ready |
|
Stylo is currently being upgraded in servo/servo#46987 which means that test results will be muddied by the upgrade. Will wait on that |
With these changes, both the `color-scheme` CSS property is supported, as well as the required logic to act upon it. Signed-off-by: Tim van der Lippe <tvanderlippe@gmail.com>
32bab7f to
7bfc5f0
Compare
|
Keeping this as draft until the Stylo upgrade has completed |
|
I'm interested in what Servo-side changes will be required for this. My tentative conclusion when I looked into this was that it might actually work entirely within Stylo (aside from the already existing theme support on the Device). |
|
These were the required changes: servo/servo#47042 (at least the ones I figured out up to this point) |
|
Ah ok, just CSS and test expectation changes. Makes sense. |
No need to wait, I can just cherry-pick it if it lands first |
|
Okay cool. In that case, both PRs are ready for review. But I think everybody basically approves already 😂 |
4 participants
With these changes, both the
color-schemeCSS property is supported, as well as the required logic to act upon it.Supersedes and closes #411
Servo PR: servo/servo#47042