Skip to content

Change repr of Servo enum PseudoElement from usize to u8 - #437

Merged
mrobinson merged 1 commit into
servo:mainfrom
SimonSapin:pseudo-element-u8
Aug 4, 2026
Merged

Change repr of Servo enum PseudoElement from usize to u8#437
mrobinson merged 1 commit into
servo:mainfrom
SimonSapin:pseudo-element-u8

Conversation

@SimonSapin

@SimonSapin SimonSapin commented Aug 4, 2026

Copy link
Copy Markdown
Member

Every fragment in the fragment tree stores:

pub struct PseudoElementChain {
    pub primary: Option<PseudoElement>,
    pub secondary: Option<PseudoElement>,
}

… so this change reduces memory use slightly
@SimonSapin
Change repr of Servo enum PseudoElement from usize to u8
57edfeb 
Every fragment in the fragment tree stores:

```rust
pub struct PseudoElementChain {
    pub primary: Option<PseudoElement>,
    pub secondary: Option<PseudoElement>,
}
```

… so this change reduces memory use slightly

Signed-off-by: Simon Sapin <simon@igalia.com>
@mrobinson

mrobinson commented Aug 4, 2026

Copy link
Copy Markdown
Member

Normally we link to a Servo PR with changes, though it seems quite unlikely that this will break Servo.
@mrobinson
mrobinson added this pull request to the merge queue Aug 4, 2026
Merged via the queue into servo:main with commit e186832 Aug 4, 2026
5 checks passed
@Loirooriol

Loirooriol commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Gecko also uses u8: https://searchfox.org/firefox-main/rev/28b5e86da948982342836c3cca50049659f0dc70/servo/components/style/gecko/pseudo_element_definition.mako.rs#14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@SimonSapin @mrobinson @Loirooriol