Allow Servo to use computed @font-face ranges - #399
Merged
Conversation
Performs some changes so that Servo will be able to use these: - `ComputedFontWeightRange` - `ComputedFontStretchRange` - `ComputedFontStyleDescriptor` Signed-off-by: Oriol Brufau <obrufau@igalia.com>
Collaborator
Author
|
These changes also affect Gecko, which is being handled upstream: |
mrobinson
approved these changes
Jun 23, 2026
pull Bot
pushed a commit
to Haofei/servo
that referenced
this pull request
Jun 23, 2026
This changes `CSSFontFaceDescriptors` to use: - `ComputedFontWeightRange` instead of a pair of `FontWeight` - `ComputedFontStretchRange` instead of a pair of `FontStretch` - Stylo's `ComputedFontStyleDescriptor` instead of a similar copy of that This way we can simply use the `compute()` method of `FontWeightRange`, `FontStretchRange` and `FontFaceStyle` to compute the above. The behavior should be mostly the same, but: - Now the ranges will be sorted, if they were in the wrong order - Degrees in `font-style` will be clamped within the [-90deg, 90deg] range Bumps Stylo to servo/stylo#399 Testing: Adding a test for ranges in the wrong order Signed-off-by: Oriol Brufau <obrufau@igalia.com>
Loirooriol
added a commit
that referenced
this pull request
Jul 1, 2026
Performs some changes so that Servo will be able to use these: - `ComputedFontWeightRange` - `ComputedFontStretchRange` - `ComputedFontStyleDescriptor` Servo PR: servo/servo#45821 Signed-off-by: Oriol Brufau <obrufau@igalia.com>
lando-worker Bot
pushed a commit
to mozilla-firefox/firefox
that referenced
this pull request
Jul 7, 2026
…fox-style-system-reviewers,emilio Imports servo/stylo#399, with some extra changes. Differential Revision: https://phabricator.services.mozilla.com/D310930
github-actions Bot
pushed a commit
to longvatrong111/stylo
that referenced
this pull request
Jul 8, 2026
…fox-style-system-reviewers,emilio Imports servo#399, with some extra changes. Differential Revision: https://phabricator.services.mozilla.com/D310930
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performs some changes so that Servo will be able to use these:
ComputedFontWeightRangeComputedFontStretchRangeComputedFontStyleDescriptorServo PR: servo/servo#45821