Remove parse condition step_position_jump_enabled - #323
Merged
Conversation
yezhizhen
force-pushed
the
this-should-work
branch
2 times, most recently
from
March 7, 2026 06:39
695765b to
bc12e8b
Compare
Loirooriol
approved these changes
Mar 7, 2026
Member
Author
|
Pls don't merge yet to not block others. I have questions that may need further change to Servo PR: servo/servo#43061 (comment) |
Member
Author
|
@Loirooriol If the tests added look ok, can you merge this? All other browsers pass them too. |
Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>>
yezhizhen
force-pushed
the
this-should-work
branch
from
March 9, 2026 05:30
bc12e8b to
40831f6
Compare
Loirooriol
approved these changes
Mar 9, 2026
Member
Author
|
I don't know how to export this to upstream btw.. |
github-merge-queue Bot
pushed a commit
to servo/servo
that referenced
this pull request
Mar 9, 2026
…osition (#43061) Bumps stylo to servo/stylo#323 As tested with examples, all step-position keywords now work: https://drafts.csswg.org/css-easing-2/#typedef-step-position Testing: New passing WPT. Several in `moveBefore` goes from TIMEOUT to `FAIL`, as the API is not enabled in Servo. Added 4 new tests to test the proper rendering. Fixes: #43060 --------- Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
github-merge-queue Bot
pushed a commit
to servo/servo
that referenced
this pull request
Mar 9, 2026
…osition (#43061) Bumps stylo to servo/stylo#323 As tested with examples, all step-position keywords now work: https://drafts.csswg.org/css-easing-2/#typedef-step-position Testing: New passing WPT. Several in `moveBefore` goes from TIMEOUT to `FAIL`, as the API is not enabled in Servo. Added 4 new tests to test the proper rendering. Fixes: #43060 --------- Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
Collaborator
Otherwise I will do a batch export it next month. |
lando-worker Bot
pushed a commit
to mozilla-firefox/firefox
that referenced
this pull request
Apr 3, 2026
…firefox-style-system-reviewers,dshin Imports servo/stylo#323 Differential Revision: https://phabricator.services.mozilla.com/D291906
github-actions Bot
pushed a commit
to longvatrong111/stylo
that referenced
this pull request
Apr 4, 2026
…firefox-style-system-reviewers,dshin Imports servo#323 Differential Revision: https://phabricator.services.mozilla.com/D291906
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables
jump-start,jump-end,jump-none,jump-both.The feature is left here 7 years ago. As tested with examples, all
step-easing-functions work as expected.Servo PR: servo/servo#43061