layout: Make ::placeholder public and add property restriction for ::placeholder and ::marker - #43053
Merged
Merged
Conversation
|
🔨 Triggering try run (#22747209360) for Linux (WPT) |
stevennovaryo
force-pushed
the
placeholder-public
branch
from
March 6, 2026 03:07
031d881 to
7bc1ea7
Compare
Member
Author
Ah, somehow ended up with wrong commits in cargo lock. 😵💫 |
|
🔨 Triggering try run (#22747724034) for Linux (WPT) |
|
Test results for linux-wpt from try job (#22747209360): Flaky unexpected result (26)
Stable unexpected results that are known to be intermittent (17)
|
|
✨ Try run (#22747209360) succeeded. |
|
Test results for linux-wpt from try job (#22747724034): Flaky unexpected result (28)
Stable unexpected results that are known to be intermittent (15)
Stable unexpected results (13)
|
|
|
Member
Author
|
This bring us closer in terms of property restriction marker WPT test result to Firefox. https://bugzilla.mozilla.org/show_bug.cgi?id=1673735 Would be nice to log these tests though:
|
|
🔨 Triggering try run (#22751993928) for Linux (WPT) |
Member
Author
|
Testing for additional changes, adding As for the new failures, the failures are all false positive.
|
stevennovaryo
force-pushed
the
placeholder-public
branch
from
March 6, 2026 06:42
3ac6bd3 to
4165bbb
Compare
|
Test results for linux-wpt from try job (#22751993928): Flaky unexpected result (29)
Stable unexpected results that are known to be intermittent (16)
Stable unexpected results (2)
|
|
|
stevennovaryo
force-pushed
the
placeholder-public
branch
from
March 6, 2026 07:38
4165bbb to
736ab0f
Compare
Member
Author
|
This should be ready to review! I will put up the related issues (for WPTs and TODO) after the PR is merged. |
stevennovaryo
marked this pull request as ready for review
March 6, 2026 07:44
servo-highfive
added
the
S-awaiting-review
jdm
reviewed
Mar 6, 2026
| // Step 3.1: Parse pseudoElt as a <pseudo-element-selector>, and let type be the result. | ||
| // TODO: This is quite hacky and it is better to have a parsing function that is integrated with | ||
| // stylo `PseudoElement` itself. Comparing with stylo, we are now currently missing | ||
| // `::backdrop`, `::color-swatch`, and `::details-content`. |
Member
There was a problem hiding this comment.
For when we file an issue about this, we should link https://searchfox.org/firefox-main/rev/46fa95cd7f10222996ec267947ab94c5107b1475/servo/ports/geckolib/glue.rs#5195-5226 as a reference
Member
Author
There was a problem hiding this comment.
Nice, exactly what we are missing.
Loirooriol
approved these changes
Mar 7, 2026
| stylo_dom = { git = "https://github.com/stevennovaryo/stylo", branch = "placeholder-public" } | ||
| stylo_malloc_size_of = { git = "https://github.com/stevennovaryo/stylo", branch = "placeholder-public" } | ||
| stylo_static_prefs = { git = "https://github.com/stevennovaryo/stylo", branch = "placeholder-public" } | ||
| stylo_traits = { git = "https://github.com/stevennovaryo/stylo", branch = "placeholder-public" } |
Contributor
There was a problem hiding this comment.
No big deal because this will be changed after landing the Stylo PR.
But if you use git = "https://github.com/servo/stylo", rev = "refs/pull/43053/head" then the lint job won't complain (so you can know at first glance that there are no other linting problems).
servo-highfive
added
S-needs-rebase
github-merge-queue Bot
pushed a commit
to servo/stylo
that referenced
this pull request
Mar 8, 2026
…holder` and `::marker` (#322) The `::placeholder` pseudo element should be a public pseudo element. And, both `::placeholder` and `::marker` should have a property restriction as defined in the spec. In stylo, the property restriction has been computed in `PropertyFlags`. Servo PR: servo/servo#43053 Signed-off-by: stevennovaryo <steven.novaryo@gmail.com>
Signed-off-by: Jo Steven Novaryo <steven.novaryo@gmail.com>
Loirooriol
force-pushed
the
placeholder-public
branch
from
March 8, 2026 23:14
736ab0f to
f5c949f
Compare
servo-highfive
added
S-awaiting-review
Loirooriol
enabled auto-merge
March 8, 2026 23:14
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Servo side of servo/stylo#322.
Update the WPT expectation following the changes to make
::placeholderpublic and adding property restriction to::placeholderand::marker. Additionally ensure thatgetComputedStyleworks for::placeholder.Testing: Existing WPTs
Fixes: #43034
Fixes: #43035
Fixes: #19808