Skip to content

[v18.x] deps: V8: cherry-pick c875e86df1d7#2

Merged
sepehrst merged 1 commit into
sepehrst:cherrypick-v8-c875e86df1d7-v18from
sepisat0:cherrypick-v8-c875e86df1d7-v18
Feb 4, 2023
Merged

[v18.x] deps: V8: cherry-pick c875e86df1d7#2
sepehrst merged 1 commit into
sepehrst:cherrypick-v8-c875e86df1d7-v18from
sepisat0:cherrypick-v8-c875e86df1d7-v18

Conversation

@sepehrst
Copy link
Copy Markdown
Owner

@sepehrst sepehrst commented Feb 4, 2023

Original commit message:

[bigint] Convert BigInt property names to decimal

Hexadecimal/octal/binary BigInt property names should be converted
to decimal, i.e. the following object literals should all be equivalent:
var o = {0xF: 1}, p = {0xFn: 1}, q = {15: 1}, r = {15n: 1}.

Test case by yangwenming@bytedance.com, uploaded at
https://chromium-review.googlesource.com/c/v8/v8/+/3634937

Fixed: v8:10600
Change-Id: Ie1d8a16e95697cd31cbc0784843779c921ce91fa
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3642302
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80490}
Original commit message:

    [bigint] Convert BigInt property names to decimal

    Hexadecimal/octal/binary BigInt property names should be converted
    to decimal, i.e. the following object literals should all be equivalent:
    var o = {0xF: 1}, p = {0xFn: 1}, q = {15: 1}, r = {15n: 1}.

    Test case by yangwenming@bytedance.com, uploaded at
    https://chromium-review.googlesource.com/c/v8/v8/+/3634937

    Fixed: v8:10600
    Change-Id: Ie1d8a16e95697cd31cbc0784843779c921ce91fa
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3642302
    Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#80490}

Refs: v8/v8@c875e86
@sepehrst sepehrst merged commit 85c7432 into sepehrst:cherrypick-v8-c875e86df1d7-v18 Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant