Skip to content

docs: breakup examples to their own files in examples/user/user.java#370

Merged
childish-sambino merged 4 commits into
sendgrid:mainfrom
adamsau:b_326
Jul 29, 2020
Merged

docs: breakup examples to their own files in examples/user/user.java#370
childish-sambino merged 4 commits into
sendgrid:mainfrom
adamsau:b_326

Conversation

@adamsau

@adamsau adamsau commented Oct 29, 2017 •
edited by childish-sambino
Loading

Copy link
Copy Markdown
Contributor

Closes #326
Closes #375

Fix "file_lines" issue in examples/user/user.java
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 29, 2017
@adamsau

adamsau commented Oct 29, 2017

Copy link
Copy Markdown
Contributor Author

@thinkingserious created PR.
@adamsau adamsau mentioned this pull request Oct 29, 2017
Closed
@adamsau

adamsau commented Oct 29, 2017

Copy link
Copy Markdown
Contributor Author

created an issue on codeclimate annoying checkings.
#372
@thinkingserious thinkingserious added difficulty: medium fix is medium in difficulty hacktoberfest labels Oct 29, 2017
@pushkyn

pushkyn commented Oct 30, 2017

Copy link
Copy Markdown
Contributor

Looks like it also resolved #375
@mbernier mbernier mentioned this pull request Nov 1, 2017
Closed
@thinkingserious

thinkingserious commented Nov 3, 2017

Copy link
Copy Markdown
Contributor

@rivenhk

We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt.

Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!)

You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!

Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged.
@adamsau

adamsau commented Nov 3, 2017

Copy link
Copy Markdown
Contributor Author

@thinkingserious no problem! But i wonder why it cannot be merged?
@thinkingserious

thinkingserious commented Nov 3, 2017

Copy link
Copy Markdown
Contributor

Hi @rivenhk,

My apologies, this has not been merged because it has not come up for review just yet as we are processing the PRs from oldest to newest.

We had over 1,000 PRs for hacktoberfest and we are doing our best to get through them as fast as we can. Thank you for your patience.

With Best Regards,

Elmer
@thinkingserious thinkingserious changed the base branch from master to main July 28, 2020 14:33
@childish-sambino childish-sambino changed the title Fix "file_lines" issue in examples/user/user.java docs: breakup examples to their own files in examples/user/user.java Jul 29, 2020
@childish-sambino childish-sambino merged commit 195a658 into sendgrid:main Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio

5 participants

@adamsau @pushkyn @thinkingserious @childish-sambino @apigirl