Upgrade to ndk-sys 0.5.0-beta.0, ndk 0.8.0-beta.0#113
Merged
Conversation
MarijnS95
force-pushed
the
ndk-breaking-prep
branch
from
b867fcc to
fa12e0f
Compare
MarijnS95
changed the title
ndk-sys-0.5.0-beta.0, ndk-0.8.0-beta.0ndk-sys 0.5.0-beta.0, ndk 0.8.0-beta.0
rib
approved these changes
Aug 15, 2023
MarijnS95
force-pushed
the
ndk-breaking-prep
branch
from
fa12e0f to
499d095
Compare
MarijnS95
commented
Aug 15, 2023
Comment on lines
+12
to
+13
| ndk-sys = "0.5.0-beta.0" | ||
| ndk = "0.8.0-beta.0" |
Member
Author
There was a problem hiding this comment.
@rib fwiw the Cargo.locks aren't checked in for the example, but they aren't in .gitignore either it seems.
Member
There was a problem hiding this comment.
right, probably because the examples were copied from rust-android-examples where I intentionally have Cargo.lock files.
should add to .gitignore
Member
Author
There was a problem hiding this comment.
Can drive-by fix that perhaps... but the CI is already green now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on rust-mobile/ndk#420.