Skip to content

rustdoc: fix rust-logo.png being included with the wrong name #64916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

rustdoc: fix rust-logo.png being included with the wrong name #64916

wants to merge 1 commit into from

Conversation

@pietroalbini
Copy link
Member

@pietroalbini pietroalbini commented Sep 30, 2019 •
edited
Loading

During a refactoring in #64443 a typo was introduced in rustdoc's html renderer, and rust-logo.png was saved as rust-log.png. This fixes the regression by restoring the proper file name.

r? @Mark-Simulacrum
@pietroalbini
rustdoc: fix rust-logo.png being included with the wrong name
d2d0880 
During a refactoring in rust-lang#64443 a typo was introduced in rustdoc's html
renderer, and rust-logo.png was saved as rust-log.png. This fixes the
regression by restoring the proper file name.
@GuillaumeGomez
Copy link
Member

Thanks!

@bors: r+ rollup
@bors
Copy link
Collaborator

bors commented Sep 30, 2019

📌 Commit d2d0880 has been approved by GuillaumeGomez
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 30, 2019
@jonas-schievink
Copy link
Contributor

Duplicate of #64904
@jonas-schievink jonas-schievink marked this as a duplicate of #64904 Sep 30, 2019
@pietroalbini
Copy link
Member Author

@bors r-

Uh, that wasn't merged on master when I started working on the PR but was merged when I checked if there weren't open PRs about this. Yay race conditions.
@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 30, 2019
@pietroalbini pietroalbini deleted the fix-rustdoc-rustlogo branch September 30, 2019 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.

5 participants

@pietroalbini @GuillaumeGomez @bors @jonas-schievink @Mark-Simulacrum