Skip to content

Expand str_as_str to more types #145933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Expand str_as_str to more types #145933

wants to merge 3 commits into from
+79 −0

Conversation

@GrigorenkoPV
Copy link
Contributor

@GrigorenkoPV GrigorenkoPV commented Aug 27, 2025 •
edited
Loading

Tracking issue: #130366
ACP: rust-lang/libs-team#643

This PR expands str_from_str feature and adds analogous methods to more types. Namely:
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 27, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 27, 2025

Error: Label needs-acp can only be set by Rust team members

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip.
@GrigorenkoPV GrigorenkoPV mentioned this pull request Aug 27, 2025
Closed
@rustbot rustbot added S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 27, 2025
@GrigorenkoPV GrigorenkoPV marked this pull request as draft August 27, 2025 21:38
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 27, 2025
@Dylan-DPC Dylan-DPC removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 19, 2025
@GrigorenkoPV GrigorenkoPV changed the title thing_as_thing Expand str_as_str to more types Nov 11, 2025
@GrigorenkoPV GrigorenkoPV marked this pull request as ready for review November 11, 2025 20:14
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 11, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 11, 2025

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer
@GrigorenkoPV
Copy link
Contributor Author

GrigorenkoPV commented Nov 11, 2025 •
edited
Loading

@rustbot label -S-waiting-on-ACP +T-libs
@rustbot ready
r?
@rustbot rustbot added T-libs Relevant to the library team, which will review and decide on the PR/issue. and removed S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. labels Nov 11, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 11, 2025

Error: Parsing assign command in comment failed: ...'' | error: specify user to assign to at >| ''...

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip.
@GrigorenkoPV GrigorenkoPV mentioned this pull request Nov 11, 2025
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

4 participants

@GrigorenkoPV @rustbot @joboet @Dylan-DPC