Skip to content

Use let chains in the new solver #143066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use let chains in the new solver #143066

wants to merge 1 commit into from
+78 −90

Conversation

compiler-errors
Copy link
Member

Self-explanatory

Let chains are stable as of today

r? lcnr
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Jun 26, 2025
compiler-errors
compiler-errors commented Jun 26, 2025
View reviewed changes
compiler-errors
compiler-errors commented Jun 26, 2025
View reviewed changes
@yotamofek yotamofek mentioned this pull request Jun 26, 2025
Merged
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Jun 27, 2025
@compiler-errors
Rollup merge of rust-lang#143073 - yotamofek:pr/fix-let-chains-fixmes…
cb0b621 
…, r=compiler-errors

Fix some fixmes that were waiting for let chains

Was inspired by looking at rust-lang#143066 and spotting two fixmes that were missed, so... r? `@compiler-errors`  😅

Yay, let chains!
rust-timer added a commit that referenced this pull request Jun 27, 2025
@rust-timer
Unrolled build for #143073
2c0d666 
Rollup merge of #143073 - yotamofek:pr/fix-let-chains-fixmes, r=compiler-errors

Fix some fixmes that were waiting for let chains

Was inspired by looking at #143066 and spotting two fixmes that were missed, so... r? `@compiler-errors`  😅

Yay, let chains!
lcnr
lcnr reviewed Jun 27, 2025
View reviewed changes
compiler/rustc_next_trait_solver/src/solve/assembly/structural_traits.rs
if let ty::Alias(ty::Projection, alias_ty) = ty.kind()
&& let Some(term) = self.try_eagerly_replace_alias(alias_ty.into())?
{
return Ok(term.expect_ty());
}
Copy link
Contributor

@lcnr lcnr Jun 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vibe, no longer early return, just use else?
lcnr
lcnr reviewed Jun 27, 2025
View reviewed changes
Copy link
Contributor

@lcnr lcnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with or without converting the relevant functions to if <let-chain> { value } else { value } instead of an explicit early return
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
3 participants
@compiler-errors @lcnr @rustbot