-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Clippy subtree update #143064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Clippy subtree update #143064
Conversation
Fix false positives on broken link detection Refactor variable names Fix doc comment about broken link lint Refactor, remove not used variable Improve broken link to catch more cases and span point to whole link Include reason why a link is considered broken Drop some checker because rustdoc already warn about them Refactor to use a single enum instead of multiple bool variables Fix lint warnings Rename function to collect broken links Warn directly instead of collecting all entries first Iterate directly rather than collecting Temporary change to confirm with code reviewer the next steps Handle broken links as part of the fake_broken_link_callback handler Simplify broken link detection without state machine usage Fix typos Add url check to reduce false positives Drop reason enum as there is only one reason Fix duplicated diagnostics Fix linter
For example, adding `*` in front of `*expression` is best shown as `**expression` rather than `*(*expression)`. This is not perfect, as it checks whether the operator is already a prefix of the expression, but it is better than it was before. For example, `&`+`&mut x` will get `&&mut x` but `&mut `+`&x` will get `&mut (&x)` as it did before this change.
If a reborrow is itself borrowed mutably, do not propose to replace it by the original reference.
…nishearth Clippy subtree update r? `@Manishearth` 1 day late. Got distracted yesterday evening and forgot about it.
…g#14906) Closes rust-lang/rust-clippy#14799 changelog: [`collapsible_else_if`] fix FP on conditionally compiled stmt
This PR announces the feature freeze period talked about in rust-lang/rust-clippy#14364 1. Add the page to the book 2. Modify the in-Github templates. 3. The third commit (to be squashed into the first) rolls the date mentioned 6 weeks (so, starting on May 9th and ending on August 20th). This gives us a comfortable buffer to make choices for this period. We have a pending discussion on the rust-lang#14364. So having some more time to make choices is very nice. I'm also preparing a Github action for detecting new lints and posting a comment about the feature freeze (being worked on in another branch) Something I'd like comment on is the date formatting. I'm not sure if "May 9th to the first of August" is the correct way of writing this information in a book 😅. changelog: Announce the feature freeze from May 9th to the first of August
r? @ghost changelog: none
Some changes occurred in src/tools/clippy cc @rust-lang/clippy These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
This comment has been minimized.
This comment has been minimized.
…ust-lang#15147) Related to [this Zulip thread](https://rust-lang.zulipchat.com/#narrow/channel/257328-clippy/topic/Reviewing.20the.20.60doc.60.20lints/with/525943439). @notriddle Would you want that? changelog: none
I expect that most people use stable Clippy. So having `master` be the first documentation link in the list is weird. Now the versions are sorted stable->beta->master.
This comment has been minimized.
This comment has been minimized.
I expect that most people use stable Clippy. So having `master` be the first documentation link in the list is weird. Now the versions are sorted stable->beta->master. changelog: none
@flip1995 You may want to cherry-pick the top commit of branch Or I can submit it separately but that would require time to be merged before this PR is rebased, as there is currently a significant backlog in the queue. |
I really need to get used to running Clippy in my sync workflow |
Thanks for the patch! Feel free to push that to the sync right away. You should have all the necessary permissions. |
This comment has been minimized.
This comment has been minimized.
This makes the intent clear, and silences Clippy.
a4066a0
to
4b3f31d
Compare
This comment was marked as resolved.
This comment was marked as resolved.
The job Click to see the possible cause of the failure (guessed by this bot)
|
r? @Manishearth
Cargo.lock update due to version bump