-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Add tracing to validate_operand
#143051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add tracing to validate_operand
#143051
Conversation
The name of the parameter changed from `op` to `val` in cbdcbf0
What happens if this gets merged without that PR? By default, all tracing is still disabled in Miri, right? |
Yes, this can be merged without issues even before rust-lang/miri#4406 |
Okay, then please make the PR & description ready for that. :) |
@rustbot ready |
@bors r+ rollup |
This PR adds a tracing call to keep track of how much time is spent in
validate_operand
andconst_validate_operand
. Let me know if more fine-grained tracing is needed (e.g. adding tracing tovalidate_operand_internal
too, which is just called from those two functions).I also fixed the rustdoc of
validate_operand
andconst_validate_operand
since it was referencing an older name for theval
parameter which was renamed in cbdcbf0.Here is some tracing output when Miri is run on
src/tools/miri/tests/pass/hello.rs
, visualizable in ui.perfetto.dev: trace-1750932222218210.jsonNote: obtaining tracing output depends on rust-lang/miri#4406, but this PR is standalone and can be merged without waiting for rust-lang/miri#4406.
r? @RalfJung