-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Enforce in bootstrap that check must have stage at least 1 #143048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
f06e41e
to
aed5f23
Compare
CC @jieyouxu (one of many heaps of bootstrap fixup commits I have in store 😆) |
This comment has been minimized.
This comment has been minimized.
☔ The latest upstream changes (presumably #141899) made this pull request unmergeable. Please resolve the merge conflicts. |
…fault check stage for it
aed5f23
to
a36ee24
Compare
Cross-compilation checks are now doing too much work, I need to take a look at how we can reduce that, because |
The job Click to see the possible cause of the failure (guessed by this bot)
|
This PR is another step towards https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/Proposal.20to.20cleanup.20stages.20and.20steps.20after.20the.20redesign/with/523586917, this time dealing with
x check
.It enforces the invariant that:
It creates a single function that prepares a proper build compiler for checking something, and also adds snapshot tests for various common check steps. Some obsolete code was also removed.
The default check stage also becomes 1, for all profiles. I tested manually that
x check std
withdownload-ci-rustc
still works and doesn't build rustc locally.Subsumes #139170.
r? @ghost