Skip to content

Rollup of 9 pull requests #126716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 32 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
a183989
Only check locally for reported errors
oli-obk Jun 17, 2024
fa2b612
Rewrite link-args-order to rmake
Oneirical Jun 6, 2024
594135e
Rewrite ls-metadata to rmake
Oneirical Jun 6, 2024
03a4259
Rewrite lto-readonly-lib to rmake
Oneirical Jun 6, 2024
62431b7
Migrate `run-make/compressed-debuginfo` to `rmake.rs`
GuillaumeGomez Jun 18, 2024
060a13e
rewrite extern-flag-rename-transitive to rmake
Oneirical Jun 18, 2024
9e2ace8
rewrite debugger-visualizer-dep-info to rmake
Oneirical Jun 18, 2024
dff354e
rewrite metadata-flag-frobs-symbols to rmake
Oneirical Jun 18, 2024
d1e8c6b
rewrite extern-overrides-distribution to rmake
Oneirical Jun 18, 2024
ec88615
Rename a bunch of things
compiler-errors Jun 18, 2024
3594a19
Taint infcx when reporting errors
oli-obk Jun 17, 2024
1cb75dc
Remove a hack that isn't needed anymore
oli-obk Jun 17, 2024
2e7e4ef
rewrite unknown-mod-stdin to rmake
Oneirical Jun 19, 2024
e4c9a8c
Const generic parameters aren't bounds, even if we end up erroring be…
oli-obk Jun 19, 2024
4226a50
rewrite and slightly rename issue-68794-textrel-on-minimal-lib
Oneirical Jun 19, 2024
e64e326
rewrite raw-dylib-cross-compilation to rmake
Oneirical Jun 19, 2024
b3c5132
make assert_stderr_contains print its contents on panic
Oneirical Jun 9, 2024
95e214d
reword the hint::blackbox non-guarantees
the8472 Jun 19, 2024
445eb08
rewrite used-cdylib-macos to rmake
Oneirical Jun 19, 2024
e7ea063
rewrite forced-unwind-terminate-pof to rmake
Oneirical Jun 18, 2024
7d9a92b
Inline `can_begin_literal_maybe_minus` call into two places.
nnethercote Jun 13, 2024
c6f7827
Introduce `can_begin_string_literal`.
nnethercote Jun 13, 2024
f44494c
Migrate `run-make/comment-section` to `rmake.rs`
Rejyr Jun 16, 2024
562a495
Rollup merge of #126095 - Oneirical:final-testination, r=jieyouxu
jieyouxu Jun 19, 2024
de12d6b
Rollup merge of #126534 - Rejyr:comment-section-migration, r=jieyouxu
jieyouxu Jun 19, 2024
f0af381
Rollup merge of #126620 - oli-obk:taint_errors, r=fee1-dead
jieyouxu Jun 19, 2024
de80d1e
Rollup merge of #126629 - GuillaumeGomez:migrate-run-make-compressed-…
jieyouxu Jun 19, 2024
a3f353b
Rollup merge of #126644 - Oneirical:testla-coil, r=jieyouxu
jieyouxu Jun 19, 2024
9452e4d
Rollup merge of #126650 - compiler-errors:renames, r=lcnr
jieyouxu Jun 19, 2024
e9efb18
Rollup merge of #126698 - Oneirical:tessteract, r=jieyouxu
jieyouxu Jun 19, 2024
285f111
Rollup merge of #126703 - the8472:on-blackbox-crypto-use, r=scottmcm
jieyouxu Jun 19, 2024
edfeec0
Rollup merge of #126708 - nnethercote:minimize-can_begin_literal_mayb…
jieyouxu Jun 19, 2024
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rewrite raw-dylib-cross-compilation to rmake
  • Loading branch information
Oneirical committed Jun 19, 2024
commit e64e326f6f04604f171957bc5154baf1f660e1c8
1 change: 0 additions & 1 deletion src/tools/tidy/src/allowed_run_make_makefiles.txt
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,6 @@ run-make/profile/Makefile
run-make/prune-link-args/Makefile
run-make/raw-dylib-alt-calling-convention/Makefile
run-make/raw-dylib-c/Makefile
run-make/raw-dylib-cross-compilation/Makefile
run-make/raw-dylib-custom-dlltool/Makefile
run-make/raw-dylib-import-name-type/Makefile
run-make/raw-dylib-inline-cross-dylib/Makefile
Expand Down
20 changes: 0 additions & 20 deletions tests/run-make/raw-dylib-cross-compilation/Makefile

This file was deleted.

41 changes: 41 additions & 0 deletions tests/run-make/raw-dylib-cross-compilation/rmake.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
// When cross-compiling using `raw-dylib`, rustc would try to fetch some
// very specific `dlltool` to complete the cross-compilation (such as `i686-w64-mingw32-dlltool`)
// when Windows only calls it `dlltool`. This test performs some cross-compilation in a
// way that previously failed due to this bug, and checks that it succeeds.
// See https://github.com/rust-lang/rust/pull/108355

//@ ignore-i686-pc-windows-msvc
// Reason: dlltool on this distribution is unable to produce x64 binaries
//@ needs-dlltool
// Reason: this is the utility being checked by this test

use run_make_support::{llvm_objdump, rust_lib_name, rustc};

fn main() {
// Build as x86 and make sure that we have x86 objects only.
rustc()
.crate_type("lib")
.crate_name("i686_raw_dylib_test")
.target("i686-pc-windows-gnu")
.input("lib.rs")
.run();
llvm_objdump()
.arg("-a")
.input(rust_lib_name("i686_raw_dylib_test"))
.run()
.assert_stdout_contains("file format coff-i386")
.assert_stdout_not_contains("file format coff-x86-64");
// Build as x64 and make sure that we have x64 objects only.
rustc()
.crate_type("lib")
.crate_name("x64_raw_dylib_test")
.target("x86-64-pc-windows-gnu")
.input("lib.rs")
.run();
llvm_objdump()
.arg("-a")
.input(rust_lib_name("i686_raw_dylib_test"))
.run()
.assert_stdout_not_contains("file format coff-i386")
.assert_stdout_contains("file format coff-x86-64");
}