Skip to content

Support another build header of Rack/openid #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 30, 2025
Merged

Support another build header of Rack/openid #19

merged 2 commits into from
Apr 30, 2025

Conversation

DianthuDia
Copy link
Contributor

@DianthuDia
Add immediate, trust_root options
83f10ae
@DianthuDia
Resolve root URI for trust_root option
6d98a73 
Example:

Rails.application.config.middleware.use OmniAuth::Builder do
  provider :open_id, trust_root: proc{|root_uri| "#{root_uri}sessions/"}
end
pboling
pboling approved these changes Apr 30, 2025
View reviewed changes
Copy link
Collaborator

@pboling pboling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Trust root was also added by another PR I just merged, but I'll resolve that separately.
@pboling pboling merged commit 81cac38 into ruby-openid:master Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@DianthuDia @pboling