Skip to content

Refactoring #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions lib/ruby_header_parser/parser.rb
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,18 @@ class Parser # rubocop:disable Metrics/ClassLength
# @return [RubyHeaderParser::Data]
attr_reader :data

DEFAULT_HEADER_FILE = "#{RbConfig::CONFIG["rubyhdrdir"]}/ruby.h".freeze

DEFAULT_INCLUDE_PATHS = [
RbConfig::CONFIG["rubyarchhdrdir"],
RbConfig::CONFIG["rubyhdrdir"],
].freeze

# @param header_file [String] path to ruby.h
# @param include_paths [Array<String>]
# @param dist_preprocessed_header_file [String]
def initialize(dist_preprocessed_header_file:, header_file: "#{RbConfig::CONFIG["rubyhdrdir"]}/ruby.h",
include_paths: [RbConfig::CONFIG["rubyarchhdrdir"], RbConfig::CONFIG["rubyhdrdir"]])
def initialize(dist_preprocessed_header_file:, header_file: DEFAULT_HEADER_FILE,
include_paths: DEFAULT_INCLUDE_PATHS)
@header_file = header_file
@include_paths = include_paths
@dist_preprocessed_header_file = dist_preprocessed_header_file
Expand Down
3 changes: 3 additions & 0 deletions sig/ruby_header_parser/parser.rbs
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ module RubyHeaderParser
attr_reader dist_preprocessed_header_file: String
attr_reader data: Data

DEFAULT_HEADER_FILE: String
DEFAULT_INCLUDE_PATHS: Array[String]

def initialize: (
dist_preprocessed_header_file: String,
?header_file: String,
Expand Down
7 changes: 0 additions & 7 deletions spec/ruby_header_parser_spec.rb

This file was deleted.

close