This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Remove default val provided to arg exception_presenter
#2221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When initializing a new instance of `FailedExampleNotification` in [1] we always use [2] to provide a correctly configured instance of `ExceptionPresenter`. Yet we pass the `exception_presenter` as a default value when instantianting `FailedExampleNotification`. It seems like this default value is only used to help us write a spec for `FailedExampleNotification`. In this commit I've removed the default value we provide to `FailedExampleNotification` (since) it's redundant and simply instantiated a new instance of the `ExceptionPresenter` in the spec for it to use. 1.) http://bit.ly/1X4NIlU 2.) http://bit.ly/1qn32Qv
|
Not sure it's worth merging this tiny PR that removes a redundant default arg, feel free to close this if you think it's not worth merging. |
|
LGTM |
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
…lue-arg Remove default val provided to arg `exception_presenter`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When initializing a new instance of
FailedExampleNotificationin [1] we alwaysuse [2] to provide a correctly configured instance of
ExceptionPresenter. Yetwe pass the
exception_presenteras a default value when instantiantingFailedExampleNotification.It seems like this default value is only used to help us write a spec for
FailedExampleNotification.In this commit I've removed the default value we provide to
FailedExampleNotification(since) it's redundant and simply instantiated anew instance of the
ExceptionPresenterin the spec for it to use.1.) http://bit.ly/1X4NIlU
2.) http://bit.ly/1qn32Qv