Skip to content
This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rspec/rspec-core
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.5.0.beta2
Choose a base ref
...
head repository: rspec/rspec-core
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.5.0.beta3
Choose a head ref
  • 17 commits
  • 22 files changed
  • 7 contributors

Commits on Mar 2, 2016

  1. the source extraction code should utilise our encoded string logic

    @JonRowe
    JonRowe committed Mar 2, 2016
    Configuration menu
    Copy the full SHA
    86f433a View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2016

  1. Delete obsolete features/Upgrade.md file.

    @myronmarston
    myronmarston committed Mar 11, 2016
    Configuration menu
    Copy the full SHA
    1c7bb7d View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2016

  1. Convert cuke to an integration spec. 

    `run_all_when_everything_filtered` will be deprecated
so we do not want to retain a cuke for it in our relish
docs.
    @myronmarston
    myronmarston committed Mar 12, 2016
    Configuration menu
    Copy the full SHA
    3a50439 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2016

  1. Implement filter_run_when_matching. 

    Closes #1920.
    @myronmarston
    myronmarston committed Mar 16, 2016
    Configuration menu
    Copy the full SHA
    7a23830 View commit details
    Browse the repository at this point in the history

  2. Bring back run_all_when_everything_filtered cuke. 

    As requested by Jon.
    @myronmarston
    myronmarston committed Mar 16, 2016
    Configuration menu
    Copy the full SHA
    c8db25e View commit details
    Browse the repository at this point in the history

  3. Merge pull request #2206 from rspec/filter-run-when-matching 

    Implement `filter_run_when_matching`.
    @JonRowe
    JonRowe committed Mar 16, 2016
    Configuration menu
    Copy the full SHA
    d65fd99 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2016

  1. Merge pull request #2183 from rspec/fix_issue_with_oddly_encoded_files 

    The source extraction code should utilise our encoded string logic
    @JonRowe
    JonRowe committed Mar 19, 2016
    Configuration menu
    Copy the full SHA
    02d2b71 View commit details
    Browse the repository at this point in the history

  2. changelog for #2183 

    [skip ci]
    @JonRowe
    JonRowe committed Mar 19, 2016
    Configuration menu
    Copy the full SHA
    319cfab View commit details
    Browse the repository at this point in the history

  3. fix edge case duration roundings

    @JonRowe
    JonRowe committed Mar 19, 2016
    Configuration menu
    Copy the full SHA
    ea54fe4 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #2208 from rspec/fix_duration 

    fix edge case duration roundings
    @JonRowe
    JonRowe committed Mar 19, 2016
    Configuration menu
    Copy the full SHA
    e23fc92 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2016

  1. Extract def-end snippets ending with "end"-only line properly

    @yujinakayama
    yujinakayama committed Mar 20, 2016
    Configuration menu
    Copy the full SHA
    4e6260b View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2016

  1. Merge pull request #2215 from rspec/support-method-definition-snippet… 

    …-extraction

Extract def-end snippets ending with "end"-only line properly
    @JonRowe
    JonRowe committed Mar 21, 2016
    Configuration menu
    Copy the full SHA
    e95067e View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2016

  1. Link to homepage using https

    @bquorning
    bquorning committed Mar 29, 2016
    Configuration menu
    Copy the full SHA
    f4af73e View commit details
    Browse the repository at this point in the history

  2. Merge pull request #2219 from bquorning/patch-1 

    Link to homepage using https
    @JonRowe
    JonRowe committed Mar 29, 2016
    Configuration menu
    Copy the full SHA
    98d8b8c View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2016

  1. Remove default val provided to arg exception_presenter 

    When initializing a new instance of `FailedExampleNotification` in [1] we always
use [2] to provide a correctly configured instance of `ExceptionPresenter`. Yet
we pass the `exception_presenter` as a default value when instantianting
`FailedExampleNotification`.

It seems like this default value is only used to help us write a spec for
`FailedExampleNotification`.

In this commit I've removed the default value we provide to
`FailedExampleNotification` (since) it's redundant and simply instantiated a
new instance of the `ExceptionPresenter` in the spec for it to use.

1.) http://bit.ly/1X4NIlU
2.) http://bit.ly/1qn32Qv
    @mrageh
    mrageh committed Apr 2, 2016
    Configuration menu
    Copy the full SHA
    2d5b8d1 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #2221 from mrageh/remove-redundant-default-value-arg 

    Remove default val provided to arg `exception_presenter`
    @myronmarston
    myronmarston committed Apr 2, 2016
    Configuration menu
    Copy the full SHA
    4b0a104 View commit details
    Browse the repository at this point in the history

  3. Temporarily set version for release of 3.5.0.beta3

    Sam Phippen committed Apr 2, 2016
    Configuration menu
    Copy the full SHA
    435b9aa View commit details
    Browse the repository at this point in the history
Loading