Skip to content

fix(contractor-onboarding) - handle empty pricing plans#1069

Merged
gabrielseco merged 2 commits into
mainfrom
fix-empty-pricing-plan
Jun 3, 2026
Merged

fix(contractor-onboarding) - handle empty pricing plans#1069
gabrielseco merged 2 commits into
mainfrom
fix-empty-pricing-plan

Conversation

@gabrielseco

@gabrielseco gabrielseco commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

The SDK could break if pricing-plans endpoints returns empty for a company. I fixed that

Note

Low Risk
Scoped to pricing-plan option building and form required-state; covered by a new integration test.

Overview
Fixes contractor onboarding Pricing Plan when company pricing plans return no EOR Monthly plan: Employer of Record is no longer offered with placeholder pricing.

useEorSubscription now returns null instead of a synthetic EOR object when the plan is missing. EOR is only added to subscription options and counted toward has available options when that data exists. A test asserts EOR is hidden when pricing_plans is empty but EOR onboarding would otherwise apply.

Reviewed by Cursor Bugbot for commit 702a12e. Bugbot is set up for automated code reviews on this repo. Configure here.

@gabrielseco gabrielseco self-assigned this Jun 2, 2026
@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

📦 Bundle Size Report

Metric Current Previous Change Status
Total (gzip) 212.85 kB 212.84 kB +11 B (+0.0%) 🔴
Total (raw) 577.15 kB 577.14 kB +11 B (+0.0%) 🔴
CSS (gzip) 20.86 kB 20.86 kB 0 B (0%) 🟢
CSS (raw) 108.83 kB 108.83 kB 0 B (0%) 🟢

Size Limits

  • ✅ Total gzipped: 212.85 kB / 250 kB (85.1%)
  • ✅ Total raw: 577.15 kB / 600 kB (96.2%)
  • ✅ CSS gzipped: 20.86 kB / 25 kB (83.4%)

Largest Files (Top 5)

  1. chunk-UGPYPGVV.js - 14 kB (0 B (0%))
  2. styles.css - 10.43 kB (0 B (0%))
  3. index.css - 10.43 kB (0 B (0%))
  4. index.js - 6.13 kB (0 B (0%))
  5. chunk-ER46UFIU.js - 5.89 kB (0 B (0%))
View All Files (314 total)
File Size (gzip) Change
chunk-UGPYPGVV.js 14 kB 0 B (0%)
styles.css 10.43 kB 0 B (0%)
index.css 10.43 kB 0 B (0%)
index.js 6.13 kB 0 B (0%)
chunk-ER46UFIU.js 5.89 kB 0 B (0%)
chunk-B437XNYG.js 5.81 kB 0 B (0%)
chunk-EFL7QFFN.js 5.29 kB 0 B (0%)
chunk-AAGHUVZO.js 4.76 kB 0 B (0%)
chunk-R3SDIPLY.js 4.47 kB new
chunk-C5PA6MLW.js 4.06 kB 0 B (0%)

✅ Bundle size check passed

@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

📊 Coverage Report

✅ Coverage increased! 🎉

Metric Current Previous Change Status
Lines 90.10% 90.10% 0%
Statements 89.75% 89.75% 0%
Functions 87.71% 87.71% 0%
Branches 80.29% 80.23% +0.05% 🟢

Detailed Breakdown

Lines Coverage
  • Covered: 3730 / 4140
  • Coverage: 90.10%
  • Change: 0% (0 lines)
Statements Coverage
  • Covered: 3790 / 4223
  • Coverage: 89.75%
  • Change: 0% (0 statements)
Functions Coverage
  • Covered: 1013 / 1155
  • Coverage: 87.71%
  • Change: 0% (0 functions)
Branches Coverage
  • Covered: 2338 / 2912
  • Coverage: 80.29%
  • Change: +0.05% (4 branches)

✅ Coverage check passed

@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Deploy preview for remote-flows ready!

Project:remote-flows
Status: ✅  Deploy successful!
Preview URL:https://remote-flows-i6iw0hf68-remotecom.vercel.app
Latest Commit:702a12e

Deployed with vercel-action

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d9537a9. Configure here.

Comment thread src/flows/ContractorOnboarding/api.ts
@gabrielseco gabrielseco merged commit 96467d2 into main Jun 3, 2026
10 checks passed
@gabrielseco gabrielseco deleted the fix-empty-pricing-plan branch June 3, 2026 06:07
@gabrielseco gabrielseco mentioned this pull request Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants