fix(contract-details) - fix state to avoid having the AI endpoint response getting resubmitted#1066
Merged
Merged
Conversation
Contributor
📦 Bundle Size Report
Size Limits
Largest Files (Top 5)
View All Files (314 total)
✅ Bundle size check passed |
Contributor
📊 Coverage Report⚪ Coverage unchanged
Detailed BreakdownLines Coverage
Statements Coverage
Functions Coverage
Branches Coverage
✅ Coverage check passed |
Contributor
|
Deploy preview for remote-flows ready!
Deployed with vercel-action |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4f4d43b. Configure here.
jordividaller
approved these changes
May 28, 2026
jordividaller
pushed a commit
that referenced
this pull request
May 29, 2026
…ponse getting resubmitted (#1066) * fix(contract-details) - fix state to avoid having the AI endpoint resubmitting * fix parsed values * add test * fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Doing a quick fix to solve the issue at hand, we remove some hidden values from getting sent actually the problem is in the architecture we have some state not synced correctly when dealing with the forms
the hidden bugs are for the architecture, I'll explain them in a loom, we'll need to fix them someday
The loom is long as I am talking what are bugs in the architecture, we don't have a clear SSOT for the values state
https://www.loom.com/share/a38fcfaa0cf04ee4b6c690bc6ad375e3?focus_title=1&muted=1&from_recorder=1
Note
Low Risk
Targeted payload shaping on contract document creation with test coverage; no auth or broad architectural changes.
Overview
Contract details submissions no longer send client-only AI state on
POSTcontract-documents:services_and_deliverables_ai_warningandservices_and_deliverables_error_skippableare stripped fromcontract_documentwhileskip_ai_checksstill comes fromfieldValueswhen the user may proceed after a skippable Remote AI error.A regression test walks the flow through a skippable AI 422, forward to preview, back to contract details, and a third submit—asserting those two keys are absent from
contract_documentbutskip_ai_checksstaystrue.Reviewed by Cursor Bugbot for commit 148959d. Bugbot is set up for automated code reviews on this repo. Configure here.