feat(review-step) - if initiated move to review step#1003
Merged
Conversation
Contributor
📦 Bundle Size Report
Size Limits
Largest Files (Top 5)
View All Files (312 total)
✅ Bundle size check passed |
Contributor
📊 Coverage Report✅ Coverage increased! 🎉
Detailed BreakdownLines Coverage
Statements Coverage
Functions Coverage
Branches Coverage
✅ Coverage check passed |
Contributor
|
Deploy preview for remote-flows ready!
Deployed with vercel-action |
gabrielseco
commented
May 13, 2026
gabrielseco
commented
May 13, 2026
gabrielseco
commented
May 13, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f1a7629. Configure here.
jordividaller
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
When the employment returns initiated which could happen after you invite the user, we don't move the user to the review step in both contractor management && onboarding flow
if we don't do this, when users try to edit an employment the API will fail as initiated definition is
Solution
For both flows, we put the initiated status on the utils constants to make this work
How to test
From what we've seen if the user.email is already on the system in my case ggarciaseco@gmail.com, in partners is where the initiated happened
Loom
https://www.loom.com/share/60b799d9e668451e99d904091b4c5f71
Note
Medium Risk
Changes onboarding/contractor flows to treat the
initiatedemployment status as read-only and disable invites, which affects core navigation and invite behavior across multiple flows but is localized to status gating logic.Overview
Ensures employments in
initiatedstate are treated like other read-only statuses by addinginitiatedto the review-step allowed list in bothOnboardingandContractorOnboarding, so users are auto-routed to the review step instead of being allowed to edit.Updates invite behavior to prevent sending invites when status is
initiated:OnboardingInvitenow disables its button based ononboardingBag.canInvite(andinitiatedis included indisabledInviteButtonEmploymentStatus), and the exampleReviewOnboardingStepno longer passes/uses a separatecanInviteprop.Tests are expanded/adjusted to cover
initiatedfor auto-navigation and to assert invite buttons are disabled forinitiated, with additional waits to avoid timing flakiness aroundcanInviteresolution.Reviewed by Cursor Bugbot for commit 78c5faa. Bugbot is set up for automated code reviews on this repo. Configure here.