Skip to content

fix: insert entry during iterating over a map #3398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ndyakov merged 1 commit into from
Jun 9, 2025
Merged

fix: insert entry during iterating over a map #3398

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: insert entry during iterating over a map 
Signed-off-by: fukua95 <[email protected]>
  • Loading branch information
@cxljs
cxljs committed Jun 8, 2025
commit b1090c1623e6d2c9571b6d701b979ec98deb2a2e
9 changes: 4 additions & 5 deletions command.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3584,15 +3584,14 @@ func (c *cmdsInfoCache) Get(ctx context.Context) (map[string]*CommandInfo, error
return err
}

lowerCmds := make(map[string]*CommandInfo, len(cmds))

// Extensions have cmd names in upper case. Convert them to lower case.
for k, v := range cmds {
lower := internal.ToLower(k)
if lower != k {
cmds[lower] = v
}
lowerCmds[internal.ToLower(k)] = v
}

c.cmds = cmds
c.cmds = lowerCmds
return nil
})
return c.cmds, err
Expand Down
Loading