Skip to content

Eliminate redundant dial mutex causing unbounded connection queue contention #3088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ofekshenawa merged 3 commits into from
Nov 20, 2024
Merged

Eliminate redundant dial mutex causing unbounded connection queue contention #3088

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fedd45f
Eliminate redundant dial mutex causing unbounded connection queue con…
LINKIWI Aug 10, 2024
8975e1e
Dialer connection timeouts unit test
LINKIWI Aug 10, 2024
7532edf
Merge branch 'master' into redundant-dial-mutex
ofekshenawa Nov 13, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Eliminate redundant dial mutex causing unbounded connection queue con… 
…tention
  • Loading branch information
@LINKIWI
LINKIWI committed Aug 10, 2024
commit fedd45f443c653f4bd8003db851daff3d2af01a9
2 changes: 0 additions & 2 deletions redis.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,8 +176,6 @@ func (hs *hooksMixin) withProcessPipelineHook(
}

func (hs *hooksMixin) dialHook(ctx context.Context, network, addr string) (net.Conn, error) {
hs.hooksMu.Lock()
defer hs.hooksMu.Unlock()
return hs.current.dial(ctx, network, addr)
}

Expand Down